-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(protocol-designer): fix slot details width and OT-2 deck view size #17640
base: chore_release-pd-8.4.3
Are you sure you want to change the base?
Conversation
fix slot details width and ot-2 deck view size close AUTH-1505
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore_release-pd-8.4.3 #17640 +/- ##
==========================================================
+ Coverage 18.62% 18.64% +0.01%
==========================================================
Files 2743 2744 +1
Lines 211706 211737 +31
Branches 6534 6538 +4
==========================================================
+ Hits 39439 39472 +33
+ Misses 172267 172265 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
return '70%' | ||
} | ||
return '100%' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protocol-designer/src/pages/Designer/DeckSetup/DeckSetupContainer.tsx
Outdated
Show resolved
Hide resolved
components/src/hardware-sim/RobotCoordinateSpace/RobotCoordinateSpaceWithRef.tsx
Outdated
Show resolved
Hide resolved
transform={ | ||
tab === 'protocolSteps' && robotType === OT2_ROBOT_TYPE | ||
? 'scale(1.3, -1.3)' | ||
: 'scale(1, -1)' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the previous commit used fixed viewBox for OT-2 + protocol steps but it needed to pass additional prop to the component that made the component messy.
actually this is not a good way but it would be better to make the component messy and OT-2 + protocol steps has the container size limitation.
if you have any better idea, please let me know.
Overview
fix slot details width and OT-2 deck view size
close AUTH-1505
Test Plan and Hands on Testing
OT-2
for zoom, the zoomed slot size is the same as production/8.4.3
Flex
for zoom, the zoomed slot size is the same as production/8.4.3
Changelog
Review requests
Risk assessment
mid