Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): fix slot details width and OT-2 deck view size #17640

Open
wants to merge 8 commits into
base: chore_release-pd-8.4.3
Choose a base branch
from

Conversation

koji
Copy link
Contributor

@koji koji commented Mar 4, 2025

Overview

fix slot details width and OT-2 deck view size

close AUTH-1505

Test Plan and Hands on Testing

OT-2

  1. create or import an OT-2 protocol
  2. go to edit protocol
  3. check the followings
    for zoom, the zoomed slot size is the same as production/8.4.3
  • starting deck
  • zoom (clicking a slot)
  • protocol steps

Flex

  1. create or import a Flex protocol
  2. go to edit protocol
  3. check the followings
    for zoom, the zoomed slot size is the same as production/8.4.3
  • starting deck
  • zoom (clicking a slot)
  • protocol steps

Changelog

Review requests

Risk assessment

mid

fix slot details width and ot-2 deck view size

close AUTH-1505
@koji koji changed the base branch from edge to chore_release-pd-8.4.3 March 4, 2025 00:08
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 86.90476% with 11 lines in your changes missing coverage. Please review.

Project coverage is 18.64%. Comparing base (624a265) to head (54b22d6).

Files with missing lines Patch % Lines
...rc/pages/Designer/DeckSetup/DeckSetupContainer.tsx 67.64% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           chore_release-pd-8.4.3   #17640      +/-   ##
==========================================================
+ Coverage                   18.62%   18.64%   +0.01%     
==========================================================
  Files                        2743     2744       +1     
  Lines                      211706   211737      +31     
  Branches                     6534     6538       +4     
==========================================================
+ Hits                        39439    39472      +33     
+ Misses                     172267   172265       -2     
Flag Coverage Δ
protocol-designer 18.64% <86.90%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/Designer/DeckSetup/HoverSlotDetailsContainer.tsx 100.00% <100.00%> (ø)
...col-designer/src/pages/Designer/DeckSetup/utils.ts 57.06% <100.00%> (+1.63%) ⬆️
...rc/pages/Designer/DeckSetup/DeckSetupContainer.tsx 73.20% <67.64%> (-0.96%) ⬇️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji added the authorship label Mar 4, 2025
return '70%'
}
return '100%'
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

support 5 cases (except OT-2 Deck + Protocol Steps)

container_size_cases

@koji koji requested review from ncdiehl11 and jerader March 6, 2025 01:44
@koji koji marked this pull request as ready for review March 6, 2025 01:44
@koji koji requested review from a team as code owners March 6, 2025 01:44
@koji koji removed request for a team March 6, 2025 01:54
Comment on lines +259 to +263
transform={
tab === 'protocolSteps' && robotType === OT2_ROBOT_TYPE
? 'scale(1.3, -1.3)'
: 'scale(1, -1)'
}
Copy link
Contributor Author

@koji koji Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the previous commit used fixed viewBox for OT-2 + protocol steps but it needed to pass additional prop to the component that made the component messy.

actually this is not a good way but it would be better to make the component messy and OT-2 + protocol steps has the container size limitation.
if you have any better idea, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant