fix(shared-data): tc lids are schema v2 now #17427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to not use any schema v3 labware in 8.3 because we're going to change the schema. The thermocycler lids were only available in schema 3. Change that by making the lid v1 def a schema 2 def, and making a lid v2 def that is a schema 3 def. All the data is the same, and we even kept the stackLimit and added it to labware schema 2, so all the machine behavior should be exactly the same. The only other thing that's not in schema 2 now is the new lid stuff support, but that code isn't in 8.3 so we should be good. Closes EXEC-1180
sfoster1
requested review from
jerader,
vegano1 and
CaseyBatten
and removed request for
a team
y3rsh
added
the
gen-analyses-snapshot-pr
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #17429 |
…shots (#17429) This PR was requested on the PR #17427 Co-authored-by: y3rsh <[email protected]>
SyntaxColoring
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to not use any schema v3 labware in 8.3 because we're going to change the schema. The thermocycler lids were only available in schema
3. Change that by making the lid v1 def a schema 2 def, and making a lid v2 def that is a schema 3 def.
All the data is the same, and we even kept the stackLimit and added it to labware schema 2, so all the machine behavior should be exactly the same. The only other thing that's not in schema 2 now is the new lid stuff support, but that code isn't in 8.3 so we should be good.
Closes EXEC-1180
review
testing