Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(robot-server): Fix more Pydantic warnings #17174

Open
wants to merge 3 commits into
base: edge
Choose a base branch
from
Open

refactor(robot-server): Fix more Pydantic warnings #17174

wants to merge 3 commits into from

Conversation

SyntaxColoring
Copy link
Contributor

@SyntaxColoring SyntaxColoring commented Dec 23, 2024 •
edited
Loading

Changelog

  • There was a scary-looking warning coming out of robot-server's tests, but it turns out to be a harmless side effect of the way that one of the tests was working. This silences the warning. Closes EXEC-1071.
  • Rename an instance of regex -> pattern per FastAPI+Pydantic deprecation notices.

Test Plan and Hands on Testing

None needed.

Review requests

None.

Risk assessment

No risk.

@SyntaxColoring SyntaxColoring requested a review from a team as a code owner December 23, 2024 21:43
@SyntaxColoring SyntaxColoring changed the title test(robot-server): Ignore expected serialization warning refactor(robot-server): Fix more Pydantic warnings Dec 23, 2024
TamarZanzouri
TamarZanzouri approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TamarZanzouri TamarZanzouri TamarZanzouri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SyntaxColoring @TamarZanzouri