fix(protocol-designer): add fallback for well order #16956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a case where in batch edit move liquid toolbox, well order was set to null, displaying an unknown translation in the WellOrder component. This PR refactors the util used to set the first and second well order values, providing a fallback if the value is null.
jerader
reviewed
Nov 22, 2024
protocol-designer/src/pages/Designer/ProtocolSteps/BatchEditToolbox/BatchEditMixTools.tsx
Outdated
Show resolved
Hide resolved
jerader
reviewed
Nov 22, 2024
| 'mix_wellOrder_first', | ||
| 't2b' | ||
| )} | ||
| secondValue={getWellOrderFieldValue( |
There was a problem hiding this comment.
same here, propsForFields.mix_wellOrder_second?.value ?? 'l2r'
jerader
reviewed
Nov 22, 2024
...ocol-designer/src/pages/Designer/ProtocolSteps/BatchEditToolbox/BatchEditMoveLiquidTools.tsx
Outdated
Show resolved
Hide resolved
jerader
approved these changes
Nov 22, 2024
This reverts commit f358c06.
ncdiehl11
force-pushed
the
fix_pd-batchedit-wellorder
branch
from
f358c06 to
86704da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes a case where in batch edit move liquid toolbox, well order was set to null, displaying an
unknown translation in the WellOrder component. This PR refactors the util used to set the first and
second well order values, providing a fallback if the value is null.
reference
Test Plan and Hands on Testing
Changelog
Review requests
see test plan
Risk assessment
low