Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix intervention modal icon sizing #16940

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Nov 21, 2024

Overview

Fixes a regression introduced by #16916. We use InterventionalModal in three places: protocol run interventions, Error Recovery, and incompatible modules. ER and run interventions have different icon sizing, which I didn't catch during this ticket.

Let's just specify an override for the icon sizing to keep this simple. It's not a design component.

Current Behavior

Screenshot 2024-11-21 at 3 01 35 PM

Fixed Behavior

Screenshot 2024-11-21 at 3 01 25 PM Screenshot 2024-11-21 at 3 04 18 PM

Just to show there's no regression.

Test Plan and Hands on Testing

  • See images.

Risk assessment

low

@mjhuff mjhuff requested a review from a team as a code owner November 21, 2024 20:12
Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICEEEEE

@mjhuff mjhuff merged commit 4f061f7 into chore_release-8.2.0 Nov 21, 2024
40 checks passed
@mjhuff mjhuff deleted the app_fix-icon-sizing branch November 21, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants