fix(protocol-designer): fix navbar z-index issue #16910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix navbar z-index issue close RQA-3641
|
one more thing is a bit buggy, i can click on the continue button in the toolbox 
|
this comes from Toolbox's |
koji
commented
Nov 20, 2024
| @@ -140,7 +140,6 @@ export function Toolbox(props: ToolboxProps): JSX.Element { | |||
| <Box | |||
| padding={SPACING.spacing16} | |||
| boxShadow={isScrolledToBottom ? 'none' : '0px -4px 12px #0000001a'} | |||
| zIndex={3} | |||
There was a problem hiding this comment.
Since the ToolBox has z-index: 10 set, I think it should be fine to remove it.
jerader
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fix navbar z-index issue
close RQA-3641
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment