Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shared-data): add lv96 shared data definitions #16749

Merged
merged 7 commits into from
Nov 12, 2024
Merged

feat(shared-data): add lv96 shared data definitions #16749

merged 7 commits into from
Nov 12, 2024

Conversation

ryanthecoder
Copy link
Contributor

Overview

Add 200ul pipette definitions to shared data

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

This will not work out of the box until we get aspirate/dispense pipette functions from the factory.

@ryanthecoder ryanthecoder requested a review from a team as a code owner November 8, 2024 21:00
sfoster1
sfoster1 requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an inadvertent change to the p1000 3.6, and some values that should be updated in the new general config (remove 1000ul tips, this is where the shaft mm changes should go)

shared-data/pipette/definitions/2/general/ninety_six_channel/p1000/3_6.json Outdated Show resolved Hide resolved
shared-data/pipette/definitions/2/general/ninety_six_channel/p200/3_0.json Outdated Show resolved Hide resolved
shared-data/pipette/definitions/2/general/ninety_six_channel/p200/3_0.json Outdated Show resolved Hide resolved
shared-data/pipette/definitions/2/general/ninety_six_channel/p200/3_0.json Outdated Show resolved Hide resolved
@ryanthecoder ryanthecoder requested a review from a team as a code owner November 12, 2024 15:08
@ryanthecoder ryanthecoder requested review from smb2268 and removed request for a team November 12, 2024 15:08
sfoster1
sfoster1 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but also update command schema 11

@ryanthecoder ryanthecoder requested a review from a team as a code owner November 12, 2024 15:30
@ryanthecoder ryanthecoder merged commit 74312f2 into edge Nov 12, 2024
57 checks passed
ryanthecoder added a commit that referenced this pull request Nov 14, 2024
@ryanthecoder
feat(shared-data): add lv96 shared data definitions (#16749)
e607918 
<!--
Thanks for taking the time to open a Pull Request (PR)! Please make sure
you've read the "Opening Pull Requests" section of our Contributing
Guide:

https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests

GitHub provides robust markdown to format your PR. Links, diagrams,
pictures, and videos along with text formatting make it possible to
create a rich and informative PR. For more information on GitHub
markdown, see:

https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax

To ensure your code is reviewed quickly and thoroughly, please fill out
the sections below to the best of your ability!
-->

Add 200ul pipette definitions to shared data
<!--
Describe your PR at a high level. State acceptance criteria and how this
PR fits into other work. Link issues, PRs, and other relevant resources.
-->

<!--
Describe your testing of the PR. Emphasize testing not reflected in the
code. Attach protocols, logs, screenshots and any other assets that
support your testing.
-->

<!--
List changes introduced by this PR considering future developers and the
end user. Give careful thought and clear documentation to breaking
changes.
-->

<!--
- What do you need from reviewers to feel confident this PR is ready to
merge?
- Ask questions.
-->

This will not work out of the box until we get aspirate/dispense pipette
functions from the factory.
<!--
- Indicate the level of attention this PR needs.
- Provide context to guide reviewers.
- Discuss trade-offs, coupling, and side effects.
- Look for the possibility, even if you think it's small, that your
change may affect some other part of the system.
- For instance, changing return tip behavior may also change the
behavior of labware calibration.
- How do your unit tests and on hands on testing mitigate this PR's
risks and the risk of future regressions?
- Especially in high risk PRs, explain how you know your testing is
enough.
-->
ryanthecoder added a commit that referenced this pull request Nov 15, 2024
@ryanthecoder
feat(shared-data): add lv96 shared data definitions (#16749)
a940a3c 
<!--
Thanks for taking the time to open a Pull Request (PR)! Please make sure
you've read the "Opening Pull Requests" section of our Contributing
Guide:


https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests

GitHub provides robust markdown to format your PR. Links, diagrams,
pictures, and videos along with text formatting make it possible to
create a rich and informative PR. For more information on GitHub
markdown, see:


https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax

To ensure your code is reviewed quickly and thoroughly, please fill out
the sections below to the best of your ability!
-->

# Overview

Add 200ul pipette definitions to shared data
<!--
Describe your PR at a high level. State acceptance criteria and how this
PR fits into other work. Link issues, PRs, and other relevant resources.
-->

## Test Plan and Hands on Testing

<!--
Describe your testing of the PR. Emphasize testing not reflected in the
code. Attach protocols, logs, screenshots and any other assets that
support your testing.
-->

## Changelog

<!--
List changes introduced by this PR considering future developers and the
end user. Give careful thought and clear documentation to breaking
changes.
-->

## Review requests

<!--
- What do you need from reviewers to feel confident this PR is ready to
merge?
- Ask questions.
-->

## Risk assessment
This will not work out of the box until we get aspirate/dispense pipette
functions from the factory.
<!--
- Indicate the level of attention this PR needs.
- Provide context to guide reviewers.
- Discuss trade-offs, coupling, and side effects.
- Look for the possibility, even if you think it's small, that your
change may affect some other part of the system.
- For instance, changing return tip behavior may also change the
behavior of labware calibration.
- How do your unit tests and on hands on testing mitigate this PR's
risks and the risk of future regressions?
- Especially in high risk PRs, explain how you know your testing is
enough.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfoster1 sfoster1 sfoster1 approved these changes

@smb2268 smb2268 Awaiting requested review from smb2268 smb2268 is a code owner automatically assigned from Opentrons/js

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanthecoder @sfoster1