feat(hardware, shared-data, api): Support LV 96 channel #16747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
approved these changes
Nov 8, 2024
| @@ -1774,7 +1774,8 @@ | |||
| "p1000_single_gen2", | |||
| "p1000_single_flex", | |||
| "p1000_multi_flex", | |||
| "p1000_96" | |||
| "p1000_96", | |||
There was a problem hiding this comment.
this needs to be in the shared-data PR I think
shared-data/js/constants.ts
Outdated
| @@ -587,7 +588,11 @@ export const WASTE_CHUTE_STAGING_AREA_FIXTURES: CutoutFixtureId[] = [ | |||
| STAGING_AREA_SLOT_WITH_WASTE_CHUTE_RIGHT_ADAPTER_NO_COVER_FIXTURE, | |||
| ] | |||
|
|
|||
| export const LOW_VOLUME_PIPETTES = ['p50_single_flex', 'p50_multi_flex'] | |||
| export const LOW_VOLUME_PIPETTES = [ | |||
There was a problem hiding this comment.
this variable is used to cause PD to generate configureForVolume commands before each aspirate - the "low volume" part is "has a lowVolume liquid configuration". Will the LV96 have one?
ryanthecoder
force-pushed
the
EXEC-813-LV96-support
branch
from
3382160
to
4428bc1
Compare
ryanthecoder
force-pushed
the
EXEC-813-LV96-support
branch
from
4428bc1
to
af01c8a
Compare
ryanthecoder
added a commit
that referenced
this pull request
Nov 14, 2024
<!-- Thanks for taking the time to open a Pull Request (PR)! Please make sure you've read the "Opening Pull Requests" section of our Contributing Guide: https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests GitHub provides robust markdown to format your PR. Links, diagrams, pictures, and videos along with text formatting make it possible to create a rich and informative PR. For more information on GitHub markdown, see: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax To ensure your code is reviewed quickly and thoroughly, please fill out the sections below to the best of your ability! --> Add all of the string constants for the pipette type, and then update some of the loading/checking of pipette types that were explicitly checking only the 1000ul version of the 96. <!-- Describe your PR at a high level. State acceptance criteria and how this PR fits into other work. Link issues, PRs, and other relevant resources. --> <!-- Describe your testing of the PR. Emphasize testing not reflected in the code. Attach protocols, logs, screenshots and any other assets that support your testing. --> <!-- List changes introduced by this PR considering future developers and the end user. Give careful thought and clear documentation to breaking changes. --> <!-- - What do you need from reviewers to feel confident this PR is ready to merge? - Ask questions. --> <!-- - Indicate the level of attention this PR needs. - Provide context to guide reviewers. - Discuss trade-offs, coupling, and side effects. - Look for the possibility, even if you think it's small, that your change may affect some other part of the system. - For instance, changing return tip behavior may also change the behavior of labware calibration. - How do your unit tests and on hands on testing mitigate this PR's risks and the risk of future regressions? - Especially in high risk PRs, explain how you know your testing is enough. -->
ryanthecoder
added a commit
that referenced
this pull request
Nov 15, 2024
<!-- Thanks for taking the time to open a Pull Request (PR)! Please make sure you've read the "Opening Pull Requests" section of our Contributing Guide: https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests GitHub provides robust markdown to format your PR. Links, diagrams, pictures, and videos along with text formatting make it possible to create a rich and informative PR. For more information on GitHub markdown, see: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax To ensure your code is reviewed quickly and thoroughly, please fill out the sections below to the best of your ability! --> Add all of the string constants for the pipette type, and then update some of the loading/checking of pipette types that were explicitly checking only the 1000ul version of the 96. <!-- Describe your PR at a high level. State acceptance criteria and how this PR fits into other work. Link issues, PRs, and other relevant resources. --> <!-- Describe your testing of the PR. Emphasize testing not reflected in the code. Attach protocols, logs, screenshots and any other assets that support your testing. --> <!-- List changes introduced by this PR considering future developers and the end user. Give careful thought and clear documentation to breaking changes. --> <!-- - What do you need from reviewers to feel confident this PR is ready to merge? - Ask questions. --> <!-- - Indicate the level of attention this PR needs. - Provide context to guide reviewers. - Discuss trade-offs, coupling, and side effects. - Look for the possibility, even if you think it's small, that your change may affect some other part of the system. - For instance, changing return tip behavior may also change the behavior of labware calibration. - How do your unit tests and on hands on testing mitigate this PR's risks and the risk of future regressions? - Especially in high risk PRs, explain how you know your testing is enough. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add all of the string constants for the pipette type, and then update some of the loading/checking of pipette types that were explicitly checking only the 1000ul version of the 96.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment