feat(api, robot-server): get historical and current command errors

robot-server/robot_server/persistence/_migrations/v7_to_v8.py

@@ -88,9 +88,9 @@ def _migrate_command_table_with_new_command_error_col_and_command_status(
     for row in dest_transaction.execute(select_commands).all():
         data = json.loads(row.command)
         new_command_error = (
-            # Account for old_row.command["error"] being NULL.
+            # Account for old_row.command["error"] being null.
             None
-            if "error" not in row.command or data["error"] == None  # noqa: E711
+            if "error" not in row.command or data["error"] is None
             else json.dumps(data["error"])
         )
         # parse json as enum

robot-server/robot_server/persistence/tables/__init__.py

@@ -17,6 +17,7 @@
     ProtocolKindSQLEnum,
     BooleanSettingKey,
     DataFileSourceSQLEnum,
+    CommandStatusSQLEnum,
 )
 
 
@@ -36,4 +37,5 @@
     "ProtocolKindSQLEnum",
     "BooleanSettingKey",
     "DataFileSourceSQLEnum",
+    "CommandStatusSQLEnum",
 ]

robot-server/robot_server/runs/run_store.py

@@ -45,7 +45,7 @@
 
 from .action_models import RunAction, RunActionType
 from .run_models import RunNotFoundError
-from ..persistence.tables.schema_8 import CommandStatusSQLEnum
+from ..persistence.tables import CommandStatusSQLEnum
 
 log = logging.getLogger(__name__)
 
@@ -613,19 +613,26 @@ def get_commands_errors_slice(
             actual_cursor = cursor if cursor is not None else count_result - length
             # Clamp to [0, count_result).
             actual_cursor = max(0, min(actual_cursor, count_result - 1))
+            select_command_errors = (
+                sqlalchemy.select(run_command_table)
+                .where(run_command_table.c.command_error is not None)
+                .subquery()
+            )
             select_slice = (
-                sqlalchemy.select(
-                    run_command_table.c.index_in_run,
-                    run_command_table.c.command_error,
-                )
+                sqlalchemy.select(run_command_table.c.command_error)
                 .where(
                     and_(
                         run_command_table.c.run_id == run_id,
                         run_command_table.c.index_in_run >= actual_cursor,
                         run_command_table.c.index_in_run < actual_cursor + length,
-                        run_command_table.c.command_error is not None,
                     )
                 )
+                .join_from(
+                    run_command_table,
+                    select_command_errors,
+                    onclause=run_command_table.c.index_in_run
+                    == select_command_errors.c.index_in_run,
+                )
                 .order_by(run_command_table.c.index_in_run)
             )
             slice_result = transaction.execute(select_slice).all()

robot-server/tests/runs/test_run_store.py

@@ -361,6 +361,8 @@ async def test_update_run_state_command_with_errors(
         cursor=0,
     )
 
+    print(command_errors_result)
+
     assert command_errors_result.commands_errors == [
         item.error for item in protocol_commands_errors
     ]