Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol-designer): update heater shaker form fields #16580

Merged
merged 4 commits into from
Oct 23, 2024
Merged

feat(protocol-designer): update heater shaker form fields #16580

merged 4 commits into from
Oct 23, 2024

Commits on Oct 23, 2024

  1. feat(protocol-designer): update heater shaker form fields 

    This PR overhauls the new PD heater shaker form. I consolidate shake duration form field (minutes
and seconds) into a single time field. I also fix the function of the HS form toggle input fields
and update errors, maskers, and default values for the form.

Closes AUTH-864, Closes AUTH-966
    @ncdiehl11
    ncdiehl11 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    33be0d7 View commit details
    Browse the repository at this point in the history

  2. pass proper save callback to addpause modal

    @ncdiehl11
    ncdiehl11 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d97da26 View commit details
    Browse the repository at this point in the history

  3. fix size prop for icon

    @ncdiehl11
    ncdiehl11 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    5df58e3 View commit details
    Browse the repository at this point in the history

  4. update toggle button icon size

    @ncdiehl11
    ncdiehl11 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c4152db View commit details
    Browse the repository at this point in the history