feat: Opentrons ai client landing page #16552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbelginetw
requested review from
koji,
y3rsh,
shlokamin,
Elyorcv and
connected-znaim
fbelginetw
changed the title
shlokamin
approved these changes
Oct 23, 2024
| const { getAccessToken } = useGetAccessToken() | ||
| const trackEvent = useTrackEvent() | ||
|
|
||
| initializeMixpanel(mixpanel) |
There was a problem hiding this comment.
this should probably be done outside of the component so we don't initialize mixpanel multiple times right? otherwise we'll call this on every render. maybe we can have a single initialize function that gets called at the root of the project or something
| import type { RouteProps } from './resources/types' | ||
|
|
||
| const opentronsAIRoutes: RouteProps[] = [ | ||
| // replace Landing with the correct component |
There was a problem hiding this comment.
is this meant to be done later?
| import { getHasOptedIn } from './selectors' | ||
|
|
||
| export const getIsProduction = (): boolean => | ||
| global.location.host === 'designer.opentrons.com' // UPDATE THIS TO CORRECT URL |
There was a problem hiding this comment.
i think this should be ai.opentrons.com
There was a problem hiding this comment.
also is this being used anywhere? i dont think we need this since the correct mixpanel token gets injected at build time
| // Register "super properties" which are included with all events | ||
| mixpanel.register({ | ||
| appVersion: 'test', // TODO update this? | ||
| // NOTE(IL, 2020): Since PD may be in the same Mixpanel project as other OT web apps, this 'appName' property is intended to distinguish it |
There was a problem hiding this comment.
lets remove this comment, its only relevant to PD
|
|
||
| /** ChatDataAtom is for chat data (user prompt and response from OpenAI API) */ | ||
| export const chatDataAtom = atom<ChatData[]>([]) | ||
|
|
||
| export const chatHistoryAtom = atom<Chat[]>([]) | ||
|
|
||
| export const tokenAtom = atom<string | null>(null) | ||
|
|
||
| export const mixpanelAtom = atom<Mixpanel | null>({ | ||
| analytics: { hasOptedIn: true }, // TODO: set to false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors Opentrons AI Client to match the new design. It also adds the mixpanel files for tracking analytics.
Test Plan and Hands on Testing
Still wip, but tested manually the landing page and its buttons, and if mixpanel is tracking the events.
Changelog
Review requests
Risk assessment
It breaks the current Opentrons AI client, as it's being remade from the ground up.