fix(app): fix choose csv file button label #15529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add ternary for choose csv button
ncdiehl11
reviewed
Jun 26, 2024
Comment on lines
156
to
162
| console.log('isLoading', isLoading) | ||
| console.log('startSetup', startSetup) | ||
| console.log('enableCsvFile', enableCsvFile) | ||
| console.log( | ||
| 'result', | ||
| mostRecentAnalysis?.result === 'parameter-value-required' | ||
| ) |
There was a problem hiding this comment.
thanks, I'll remove them.
| @@ -157,6 +170,10 @@ export function ProtocolSetupParameters({ | |||
| }} | |||
| onClickButton={handleConfirmValues} | |||
| buttonText={t('confirm_values')} | |||
| buttonIsDisabled={ | |||
| enableCsvFile && | |||
| mostRecentAnalysis?.result === 'parameter-value-required' | |||
There was a problem hiding this comment.
I refactored the getAnalysisStatus utility in this PR, but this works for now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
update the label for choose csv button, confirm values disabled condition and add
useFeatureFlagFor
ChooseCSVbutton, we need check two things. One is type and the other is analysis's reuslt.if type is csv_file and result is ok => green background('ready') and display
file nameif type is csv_file and result is parameter-value-required => background ('not ready') and display
requiredclose AUTH-539
before
after
Test Plan
set up a protocol run with the following protocol
rtp_phase2_test.py.zip
Changelog
Review requests
Risk assessment
low