refactor(protocol-engine): Minor CommandStore/CommandView refactors #15501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
commented
Jun 24, 2024
| if self._state.queue_status == QueueStatus.AWAITING_RECOVERY: | ||
| self._state.recovery_target_command_id = None | ||
| self._state.recovery_target_command_id = None |
There was a problem hiding this comment.
@TamarZanzouri Do you remember if there was any particular reason this was conditional on if self._state.queue_status == QueueStatus.AWAITING_RECOVERY? I think it's safe to remove the if statement for simplicity, but am I missing anything?
SyntaxColoring
commented
Jun 24, 2024
SyntaxColoring
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This was originally going to fix EXEC-581, but it turns out that that behavior is intentional. So now this just adds a test for the intended behavior and makes a couple of other very minor refactors.
Test plan
None needed.
Review requests
See comments below.
Risk assessment
Low.