-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): allow local editing of JSON protocols through embedded protocol designer #15492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add JSON protocol schema 8, which is similar in semantic concept to json protocol schema 7 but - Requires user specification of the schema for the command List This allows json protocols to switch which commands they're interning without requiring further bumps to the protocol schema - Does the same thing for command annotations, liquids, and labware For the same reasons. This should be a big step forward in flexibility for our protocol schemas.
…kunk_v8-with-annotations-in-analysis-and-timeline-scrubber
…tocol designer Include an experimental windowed local protocol designer within the desktop app.
b-cooper
changed the title
pd window in app
feat(app): allow local editing of JSON protocols through embedded protocol designer
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Include an experimental windowed local protocol designer within the desktop app.
TODO: add feature flag protection in app
Risk assessment
low