feat(api): add liquid presence detection to load_instrument() #15482
Conversation
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #15483 |
| @@ -62,6 +62,7 @@ def get_pipette_view( | |||
| static_config_by_id: Optional[Dict[str, StaticPipetteConfig]] = None, | |||
| flow_rates_by_id: Optional[Dict[str, FlowRates]] = None, | |||
| nozzle_layout_by_id: Optional[Dict[str, Optional[NozzleMap]]] = None, | |||
| liquid_presence_detection_by_id: Optional[Dict[str, Optional[bool]]] = None, | |||
There was a problem hiding this comment.
why Optional[bool] rather than just bool?
There was a problem hiding this comment.
The LoadPipetteParams liquidPresenceDetection is Optional
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #15483 |
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #15483 |
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #15483 |
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #15483 |
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #15483 |
This PR is an automated snapshot update request. Please review the changes and merge if they are acceptable or find you bug and fix it. Co-authored-by: pmoegenburg <[email protected]>
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #15515 |
This PR is an automated snapshot update request. Please review the changes and merge if they are acceptable or find you bug and fix it. Co-authored-by: pmoegenburg <[email protected]>
There was a problem hiding this comment.
Last thing - API verison 2.20 doesn't exist yet. We'll need to add it, which will be pretty easy, but #15507 should probably get merged first. So we can treat this as done for now and fix it up once that happens in the next day or two.
pmoegenburg
dismissed
sfoster1’s stale review
APIVersion has been bumped to 2.20
Overview
This PR adds a boolean argument to the load_instrument ProtocolContext method that enables liquid presence detection for the loaded pipette via an additional pipette state variable.
Closes EXEC-541.
Test Plan
Added tests to ensure this bool arg can only be populated in API versions 2.20 onward and when using a Flex robot.
Changelog
Review requests
Risk assessment