test(protocol-engine): Port some tests #15477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
force-pushed
the
port_some_tests
branch
from
36b9b5f
to
aa3fc31
Compare
SyntaxColoring
force-pushed
the
port_some_tests
branch
from
aa3fc31
to
91cfb83
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #15477 +/- ##
===========================================
+ Coverage 60.43% 92.43% +32.00%
===========================================
Files 154 77 -77
Lines 12119 1283 -10836
===========================================
- Hits 7324 1186 -6138
+ Misses 4795 97 -4698
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor refactors in the neighborhood of EXEC-383.
Test plan
None needed.
Changelog
CommandView.get_implicitly_active(), which was unused.CommandStoreandCommandViewtests to the new higher-level style, as opposed to testing low-levelCommandStatevalues. (See this note.)Risk assessment
Low.