Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore Release 7.4.0 #15456

Merged
merged 7 commits into from
Jul 23, 2024
Merged

Chore Release 7.4.0 #15456

merged 7 commits into from
Jul 23, 2024

Conversation

y3rsh
Copy link
Member

@y3rsh y3rsh commented Jun 18, 2024

This is the working branch for the 7.4.0 release

This release is for HEPA/UV firmware update

TODO

- [ ] @ahiuchingau is there more work to do?
- [ ] @ahiuchingau once ready, merge to edge then cherry pick gripper version PR into this branch chore_release-7.4.0

@y3rsh y3rsh added the DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available label Jun 18, 2024
@y3rsh y3rsh self-assigned this Jun 18, 2024
@y3rsh y3rsh requested review from a team as code owners June 18, 2024 17:35
@y3rsh y3rsh requested review from b-cooper and removed request for a team June 18, 2024 17:35
@vegano1
Copy link
Contributor

vegano1 commented Jun 18, 2024

@y3rsh
PR has been cherry picked
#15311

@y3rsh y3rsh changed the base branch from release to edge June 25, 2024 16:10
@y3rsh y3rsh changed the base branch from edge to release June 25, 2024 16:11
ecormany and others added 6 commits June 26, 2024 15:15
# Overview

Indicate that 7.4.0 adds support for HEPA/UV.

# Test Plan

Check in-app after alpha 0 tag is cut.

# Changelog

app-shell and api notes.

# Risk assessment

nil
## `cherry-pick` 246efcb

Must update `chore_release-7.4.0` so that windows builds work and we may
test an update. To understand the changes see #15718

Co-authored-by: Seth Foster <[email protected]>
…5741)

## `cherry-pick` afaa717

Must update `chore_release-7.4.0` so that Linux app builds work due to a
change in setuptools. To understand the changes see #15717

Co-authored-by: Ryan Howard <[email protected]>
…ip install (#15624)

## Replaces #15618 with PR against branch name ending in
`app-build-internal` to trigger a build

## Overview

- <https://opentrons.atlassian.net/browse/RQA-2830>
- `macos-11` GitHub runner was intel and now we use macos-latest that is
arm
[doc](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories)
- specify --x64 argument to electron-builder
- ~~per
[doc](https://github.com/actions/setup-python?tab=readme-ov-file#supported-architectures)
x64 python should be installed so the pip install will be the right
platform. I'm not confident in this.~~
- see comment in #15618
- we need to use the python we download on mac to do the pip install so
the installed packages match the platform correctly

## Test Plan

- [x] build locally and see that it works
- [x] watch CI and install the built package
- [x] validate that once the package dmg is x64 that analysis works
(python has packages with the right arch)

# Review requests

- This the right approach?

# Risk assessment

High because our .dmg currently cannot analyze protocols 2.0.0-alpha.0
internal release build.
Copy link

@nusrat813 nusrat813 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah!

@y3rsh y3rsh merged commit a77ffd7 into release Jul 23, 2024
122 of 125 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants