Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore remove workaround from ci #15391

Closed
wants to merge 24 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
abe1809
Update README.md
koji Apr 12, 2024
85c364c
Merge branch 'Opentrons:edge' into edge
koji Apr 16, 2024
3a71721
Merge branch 'Opentrons:edge' into edge
koji Apr 18, 2024
cb05480
Merge branch 'Opentrons:edge' into edge
koji Apr 24, 2024
9ac5cf0
Merge branch 'Opentrons:edge' into edge
koji Apr 26, 2024
65e57a2
Merge branch 'Opentrons:edge' into edge
koji Apr 29, 2024
f0ca441
Merge branch 'Opentrons:edge' into edge
koji May 4, 2024
8e2d33f
Merge branch 'Opentrons:edge' into edge
koji May 7, 2024
6a0ebf8
Merge branch 'Opentrons:edge' into edge
koji May 16, 2024
ee40beb
add .omletrc for test
koji May 17, 2024
f419b04
Merge branch 'Opentrons:edge' into edge
koji May 20, 2024
63c8e73
Merge branch 'Opentrons:edge' into edge
koji May 22, 2024
9684384
Merge branch 'Opentrons:edge' into edge
koji May 24, 2024
a2b9abf
Merge branch 'Opentrons:edge' into edge
koji May 24, 2024
2e6606c
Merge branch 'Opentrons:edge' into edge
koji May 29, 2024
aae85c0
Update SetWifiCred.tsx
koji May 29, 2024
8b94ba4
Merge branch 'Opentrons:edge' into edge
koji May 29, 2024
649d667
Merge branch 'Opentrons:edge' into edge
koji May 29, 2024
ccd6fe2
Merge branch 'Opentrons:edge' into edge
koji Jun 2, 2024
9deecdc
Merge branch 'Opentrons:edge' into edge
koji Jun 3, 2024
097f3cb
Merge branch 'Opentrons:edge' into edge
koji Jun 5, 2024
f75fd54
Merge branch 'Opentrons:edge' into edge
koji Jun 7, 2024
f5e7af4
Merge branch 'Opentrons:edge' into edge
koji Jun 11, 2024
cfdd3a4
chore: remove workaround from workflows
Jun 11, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/actions/python/setup/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ runs:
- shell: bash
run: |
if [[ "${OSTYPE}" =~ "linux" ]]; then
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update
sudo apt-get install -y --no-install-recommends libsystemd-dev
fi
Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/app-test-build-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ jobs:
node-version: '18.19.0'
- name: 'install udev'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'set complex environment variables'
id: 'set-vars'
Expand Down Expand Up @@ -120,8 +118,6 @@ jobs:
- name: 'install libudev and libsystemd'
if: startsWith(matrix.os, 'ubuntu')
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'set complex environment variables'
id: 'set-vars'
Expand Down Expand Up @@ -254,8 +250,6 @@ jobs:
- name: 'install libudev and libsystemd'
if: startsWith(matrix.os, 'ubuntu')
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'set complex environment variables'
id: 'set-vars'
Expand Down Expand Up @@ -433,8 +427,6 @@ jobs:
node-version: '18.19.0'
- name: 'install udev'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'set complex environment variables'
id: 'set-vars'
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/components-test-build-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ jobs:
node-version: '18.19.0'
- name: 'install udev for usb-detection'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'cache yarn cache'
uses: actions/cache@v3
Expand Down Expand Up @@ -81,8 +79,6 @@ jobs:
node-version: '18.19.0'
- name: 'install udev for usb-detection'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'cache yarn cache'
uses: actions/cache@v3
Expand Down Expand Up @@ -185,8 +181,6 @@ jobs:
registry-url: 'https://registry.npmjs.org'
- name: 'install udev for usb-detection'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'setup-js'
run: |
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/g-code-testing-lint-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ jobs:
fetch-depth: 0
- name: 'install udev'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- uses: 'actions/setup-node@v3'
with:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/js-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ jobs:
buildComplexEnvVars(core, context)
- name: 'install libudev for usb-detection'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'cache yarn cache'
uses: actions/cache@v3
Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/ll-test-build-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ jobs:
git checkout ${{ github.ref }}
- name: 'install libudev for usb-detection'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'cache yarn cache'
uses: actions/cache@v3
Expand Down Expand Up @@ -97,8 +95,6 @@ jobs:
node-version: '18.19.0'
- name: 'install libudev for usb-detection'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'cache yarn cache'
uses: actions/cache@v3
Expand Down Expand Up @@ -140,8 +136,6 @@ jobs:
node-version: '18.19.0'
- name: 'install libudev for usb-detection'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'cache yarn cache'
uses: actions/cache@v3
Expand Down Expand Up @@ -186,8 +180,6 @@ jobs:
node-version: '18.19.0'
- name: 'install udev for usb-detection'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'set complex environment variables'
id: 'set-vars'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ jobs:
node-version: '18.19.0'
- name: 'install udev'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'set complex environment variables'
id: 'set-vars'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ jobs:
node-version: '18.19.0'
- name: 'install udev'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'set complex environment variables'
id: 'set-vars'
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/opentrons-ai-production-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ jobs:
node-version: '18.19.0'
- name: 'install udev'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'set complex environment variables'
id: 'set-vars'
Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/pd-test-build-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ jobs:
node-version: '18.19.0'
- name: 'install udev for usb-detection'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'cache yarn cache'
uses: actions/cache@v2
Expand Down Expand Up @@ -103,8 +101,6 @@ jobs:
- name: 'install udev for usb-detection'
if: startsWith(matrix.os, 'ubuntu')
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'cache yarn cache'
uses: actions/cache@v3
Expand Down Expand Up @@ -142,8 +138,6 @@ jobs:
node-version: '18.19.0'
- name: 'install udev for usb-detection'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'cache yarn cache'
uses: actions/cache@v3
Expand Down Expand Up @@ -186,8 +180,6 @@ jobs:
node-version: '18.19.0'
- name: 'install udev for usb-detection'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'set complex environment variables'
id: 'set-vars'
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/react-api-client-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ jobs:
node-version: '18.19.0'
- name: 'install libudev for usb-detection'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'cache yarn cache'
uses: actions/cache@v3
Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/shared-data-test-lint-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,6 @@ jobs:
- name: 'install udev for usb-detection'
if: startsWith(matrix.os, 'ubuntu')
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- uses: 'actions/setup-node@v1'
with:
Expand Down Expand Up @@ -121,8 +119,6 @@ jobs:
node-version: '18.19.0'
- name: 'install udev'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'cache yarn cache'
uses: actions/cache@v3
Expand Down Expand Up @@ -166,8 +162,6 @@ jobs:
node-version: '18.19.0'
- name: 'install udev for usb-detection'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- uses: 'actions/setup-python@v4'
with:
Expand Down Expand Up @@ -236,8 +230,6 @@ jobs:
registry-url: 'https://registry.npmjs.org'
- name: 'install udev for usb-detection'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'cache yarn cache'
uses: actions/cache@v3
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/step-generation-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ jobs:
node-version: '18.19.0'
- name: 'install udev for usb-detection'
run: |
# WORKAROUND: Remove microsoft debian repo due to https://github.com/microsoft/linux-package-repositories/issues/130. Remove line below after it is resolved
sudo rm -f /etc/apt/sources.list.d/microsoft-prod.list
sudo apt-get update && sudo apt-get install libudev-dev
- name: 'cache yarn cache'
uses: actions/cache@v3
Expand Down
9 changes: 9 additions & 0 deletions .omletrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"workspaces": {
"@opentrons/components": {
"exports": {
".": […]
}
}
}
}
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Opentrons Platform

[![Codecov][codecov-badge]][codecov]
[![Codecov][codecov-badge]][codecov] [![DeepScan grade](https://deepscan.io/api/teams/19471/projects/22868/branches/681363/badge/grade.svg)](https://deepscan.io/dashboard#view=project&tid=19471&pid=22868&bid=681363)

## Overview

Expand Down
29 changes: 29 additions & 0 deletions app/src/organisms/ProtocolsLanding/MonacoEditor.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import { VFC, useRef, useState, useEffect } from 'react';

Check failure on line 1 in app/src/organisms/ProtocolsLanding/MonacoEditor.tsx

View workflow job for this annotation

GitHub Actions / js checks

'VFC' is defined but never used
import * as monaco from 'monaco-editor/esm/vs/editor/editor.api';

Check failure on line 2 in app/src/organisms/ProtocolsLanding/MonacoEditor.tsx

View workflow job for this annotation

GitHub Actions / js checks

Cannot find module 'monaco-editor/esm/vs/editor/editor.api' or its corresponding type declarations.
import styles from './Editor.module.css';

interface MonacoEditorProps {
code: string
}

export function MonacoEditor({code }:MonacoEditorProps ):JSX.Element {
const [editor, setEditor] = useState<monaco.editor.IStandaloneCodeEditor | null>(null);
const monacoEl = useRef(null);

useEffect(() => {
if (monacoEl) {
setEditor((editor) => {

Check failure on line 15 in app/src/organisms/ProtocolsLanding/MonacoEditor.tsx

View workflow job for this annotation

GitHub Actions / js checks

Parameter 'editor' implicitly has an 'any' type.
if (editor) return editor;

return monaco.editor.create(monacoEl.current!, {

Check failure on line 18 in app/src/organisms/ProtocolsLanding/MonacoEditor.tsx

View workflow job for this annotation

GitHub Actions / js checks

Forbidden non-null assertion
value: ['function x() {', '\tconsole.log("Hello world!");', '}'].join('\n'),
language: 'typescript'
});
});
}

return () => editor?.dispose();
}, [monacoEl.current]);

return <div className={styles.Editor} ref={monacoEl}></div>;

Check failure on line 28 in app/src/organisms/ProtocolsLanding/MonacoEditor.tsx

View workflow job for this annotation

GitHub Actions / js checks

'React' must be in scope when using JSX
};
Loading