Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(snapshot): major improvements #15350

Merged
merged 20 commits into from
Jun 28, 2024
Merged

test(snapshot): major improvements #15350

merged 20 commits into from
Jun 28, 2024

Conversation

y3rsh
Copy link
Member

@y3rsh y3rsh commented Jun 5, 2024 •
edited
Loading

Analyses Snapshot Improvements

GitHub cannot handle the diff so review locally.

  • change the package name from app-testing -> analyses-snapshot-testing
  • add 2.18 protocols
  • add 2.19 protocols
  • add snapshots for the newly added protocols (2.18, 2.19, Protocol Library Protocols)
  • alter all snapshots now that custom labware only shows up in the snapshot if the protocol has custom labware
  • remove the use of .env
  • improve Makefile and define all environment variables explicitly there
  • re-write README
  • create a custom snapshot extension
  • replace parts of strings that cause unnecessary diffs like traceback line and moduleId exposed in a detail string
  • add back key as it should not change
  • replace the value of all uuid fields with the string 'UUID'
  • replace the value of all timestamp fields with 'TIMESTAMP'

@y3rsh y3rsh added the DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available label Jun 5, 2024
@y3rsh y3rsh self-assigned this Jun 5, 2024
@y3rsh y3rsh requested review from a team as code owners June 5, 2024 20:59
@y3rsh y3rsh requested a review from a team as a code owner June 26, 2024 16:46
@y3rsh y3rsh requested review from brenthagen and removed request for a team June 26, 2024 16:46
@y3rsh y3rsh changed the base branch from 7.3.1-snapshot-testing to edge June 26, 2024 16:46
@y3rsh y3rsh changed the title test(snapshot): analysis changes 7.3.0 to 7.3.1-alpha.0 test(snapshot): 2.19 protocols Jun 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

A PR has been opened to address analyses snapshot changes. Please review the changes here: #15524

@y3rsh y3rsh removed the DO NOT MERGE Indicates a PR should not be merged, even if there's a shiny green merge button available label Jun 26, 2024
@y3rsh y3rsh changed the title test(snapshot): 2.19 protocols test(snapshot): major improvements Jun 28, 2024
@y3rsh y3rsh mentioned this pull request Jun 28, 2024
Closed
y3rsh
y3rsh commented Jun 28, 2024
View reviewed changes
.eslintignore Outdated Show resolved Hide resolved
DerekMaggio
DerekMaggio approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@DerekMaggio DerekMaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/analyses-snapshot-test.yaml
Comment on lines +6 to +7
ANALYSIS_REF:
description: 'Branch or tag that provides the analysis output at test runtime'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Add something like what ref you want to compare snaphsot results to

.github/workflows/analyses-snapshot-test.yaml
TEST_SOURCE:
description: 'Target for the test code'
SNAPSHOT_REF:
description: 'Branch or tag that provides the snapshot and test code at test runtime'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: what ref you want to use to run code and generate snapshots with

This is something that has always confused me every time I go to run something. So being a bit verbose would be helpful here.

If you can, you might provide a link to the README

@y3rsh y3rsh merged commit c5d543c into edge Jun 28, 2024
15 checks passed
@y3rsh y3rsh deleted the 7.3.1-shapshot-testing-2.19-protocols branch June 28, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekMaggio DerekMaggio DerekMaggio approved these changes

@brenthagen brenthagen Awaiting requested review from brenthagen brenthagen was automatically assigned from Opentrons/js

Assignees

@y3rsh y3rsh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y3rsh @DerekMaggio