chore_release-7.2.1 merge --ff-only to release #14667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes RQA-2459 Do not instantiate new notification ipcRenderer event listeners for each component that intends to subscribe to the notification server. Instead re-use the same ipcRenderer listener. This not only reduces the number of emitters created, but fixes a bug in which ipcRenderer listeners were not properly disposed.
RQA-2496 This "attach gripper" button text wasn't capitalized. Now it is.
Closes RQA-2312 We previously swallowed collision errors during fast home move and proceeded to slow home because we used to not handle encoder overflow properly and would mistakenly raise. Now that we have fixed those encoder issues, we should actually raise the error when the motor stalls.
# Overview User-facing app and robot release notes for v7.2.1. Addresses RTC-405. # Review requests Coherent, correct, and complete? # Risk assessment No risk. --------- Co-authored-by: Edward Cormany <[email protected]>
y3rsh
added
the
DO NOT MERGE
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release #14667 +/- ##
===========================================
- Coverage 67.57% 67.56% -0.02%
===========================================
Files 2521 2521
Lines 72237 72251 +14
Branches 9306 9311 +5
===========================================
- Hits 48816 48815 -1
- Misses 21226 21240 +14
- Partials 2195 2196 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Fixes [RESC-214](https://opentrons.atlassian.net/browse/RESC-214) - [x] Add simulate test that runs a protocol using `drop_tip` with no args - Add publisher.publish_context context manager when calling drop tip with no args - Add above test case to `test_simulate.py` - It seems that the simulate drop tip functionality could benefit from more robust test coverage. Should make sure that we validate all branches inside of drop_tip. But is this PR the place to do it? Very low. Just added a message and a test [RESC-214]: https://opentrons.atlassian.net/browse/RESC-214?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.2.1
Note
Once we are ready to release stable 7.2.1
When this PR is approved and checks pass we are able to
merge --ff-onlyourchore_release-7.2.1into thereleasebranch at the local command line and then push directly.Then
git tag -a v7.2.1 -m 'chore(release): 7.2.1' git log v7.2.1 --oneline -n10 git push origin v7.2.1