refactor(api,robot-server): Various small refactors #14665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help in subsequent work, where we'll rearrange how internal state keeps track of the running command.
Make it agree with the docstring of the subject function, and with the actual behavior. Also fix an accidentally duplicated command ID.
Without confirming whether this behavior is actually good or correct.
This also matches `GET /runs/{id}/commands` and `GET /maintenance_runs/{id}/commands`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14665 +/- ##
==========================================
- Coverage 67.34% 67.34% -0.01%
==========================================
Files 2485 2485
Lines 71439 71423 -16
Branches 9057 9057
==========================================
- Hits 48114 48098 -16
Misses 21173 21173
Partials 2152 2152
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sfoster1
approved these changes
Mar 15, 2024
DerekMaggio
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Various small refactors to prepare for PR #14664, which goes towards EXEC-301.
Test Plan
This is sufficiently covered by automated tests.
Changelog
See the commit messages.
Review requests
None in particular. It's probably easiest to review this commit-by-commit.
Risk assessment
Low.