refactor: use Public Sans and Reddit Mono on PAPI docs site #14662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14662 +/- ##
=======================================
Coverage 67.34% 67.34%
=======================================
Files 2485 2485
Lines 71411 71411
Branches 9036 9036
=======================================
Hits 48093 48093
Misses 21173 21173
Partials 2145 2145
Flags with carried forward coverage won't be shown. Click here to find out more. |
ecormany
force-pushed
the
docs-public-sans
branch
from
061110e
to
0d696d6
Compare
ecormany
changed the title
koji
reviewed
Aug 19, 2024
| } | ||
|
|
||
| pre, tt, code { | ||
| font-size: 0.9em; |
There was a problem hiding this comment.
need to use the parent element as the basis?
if not, recommend you use rem instead em
koji
reviewed
Aug 19, 2024
|
|
||
| /* classes for API Reference docstring signatures */ | ||
| .sig, .sig-name, code.descname, .sig-prename, .optional, .sig-paren { | ||
| font-size: 1em; |
koji
approved these changes
Aug 20, 2024
|
Going ahead and merging this so I can continue on bigger style changes (new top and bottom nav). If there are any issues caused by this PR, I can address it as part of that or in a separate followup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updating the Python API docs to use our design system proportional and fixed-width fonts.
Test Plan
Changelog
Review requests
is it pretty?
should we also get rid of Akko H1s?
is there a way to get rid of the 1px of white space between the light grey background box of
<a><code>and the dotted border below it? i've tried every CSS kludge i know of.also need testing assistance on
Risk assessment
low