-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(api): add note about speeds that cause resonance #14653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just wonder if we should give a more explicit change amount
@@ -219,6 +219,9 @@ Movement Speeds | |||
|
|||
In addition to instructing the robot where to move a pipette, you can also control the speed at which it moves. Speed controls can be applied either to all pipette motions or to movement along a particular axis. | |||
|
|||
.. note:: | |||
Like all mechanical systems, Opentrons robots have resonant frequencies that depend on their construction and current configuration. It's possible to set a speed that causes your robot to resonate, producing louder sounds than typical operation. This is safe, but if you find it annoying, increase or decrease the speed slightly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to give an explicit amount instead of "slightly", like 10% or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This OT-2 support page didn't offer much more than "try faster or slower". If someone has a number in mind, I'm happy to use it. But if we're just guessing, I think we should leave it as-is.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14653 +/- ##
=======================================
Coverage 67.34% 67.34%
=======================================
Files 2485 2485
Lines 71439 71418 -21
Branches 9057 9042 -15
=======================================
- Hits 48114 48100 -14
Misses 21173 21173
+ Partials 2152 2145 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A reasonable, straightforward, and clear explanation. Agree w/ Ed that keeping this general might be more effective than trying to pin down this behavior to a particular speed.
Gonna be presumptuous and say:
We got some questions about Flex making loud noises at certain speeds. This note gives reassurance and guidance to users who have found how to make their robot resonate 🙉
Overview
We got some questions about Flex making loud noises at certain speeds. This note gives reassurance and guidance to users who have found how to make their robot resonate 🙉
Test Plan
Sandbox
Changelog
Just the note block. Relevant methods link to this page from the API Reference, so I don't think we need to duplicate the text there.
Review requests
Good message, good words?
Risk assessment
zero