Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(app-shell): Migrate desktop app notify connectivity to discovery-client #14648

Merged
merged 39 commits into from
Mar 21, 2024
Merged

refactor(app-shell): Migrate desktop app notify connectivity to discovery-client #14648

merged 39 commits into from
Mar 21, 2024

Commits on Mar 12, 2024

  1. update constants

    @mjhuff
    mjhuff committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    421958b View commit details
    Browse the repository at this point in the history

  2. redo notify to support new connectivity and unsubscribes

    @mjhuff
    mjhuff committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    9b07898 View commit details
    Browse the repository at this point in the history

  3. add the callback to discovery

    @mjhuff
    mjhuff committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    c519ee1 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. clean up unsubscribe

    @mjhuff
    mjhuff committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    4704772 View commit details
    Browse the repository at this point in the history

  2. try/catch the webcontents send to prevent an error on app close

    @mjhuff
    mjhuff committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    f0de47d View commit details
    Browse the repository at this point in the history

  3. we don't need to pass in browserWindow now

    @mjhuff
    mjhuff committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    417b402 View commit details
    Browse the repository at this point in the history

  4. denest and consolidate everything

    @mjhuff
    mjhuff committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    2fa5cd8 View commit details
    Browse the repository at this point in the history

  5. let's try a new structure here

    @mjhuff
    mjhuff committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    c5e2ee2 View commit details
    Browse the repository at this point in the history

  6. everything in its own file

    @mjhuff
    mjhuff committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    2b10635 View commit details
    Browse the repository at this point in the history

  7. clean up index.ts

    @mjhuff
    mjhuff committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    02d9d77 View commit details
    Browse the repository at this point in the history

  8. clean up deserialize.ts

    @mjhuff
    mjhuff committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    4504ad4 View commit details
    Browse the repository at this point in the history

  9. clean up connect.ts

    @mjhuff
    mjhuff committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    1f63b4a View commit details
    Browse the repository at this point in the history

  10. clean up subscribe

    @mjhuff
    mjhuff committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    fd1c44d View commit details
    Browse the repository at this point in the history

  11. random small cleanup

    @mjhuff
    mjhuff committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    780e0c1 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. perhaps closures are the poor man's class

    @mjhuff
    mjhuff committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    b14bd61 View commit details
    Browse the repository at this point in the history

  2. pycharm fun

    @mjhuff
    mjhuff committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    ce0c2b4 View commit details
    Browse the repository at this point in the history

  3. spruce up deserialize

    @mjhuff
    mjhuff committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    3d5635b View commit details
    Browse the repository at this point in the history

  4. spruce up index

    @mjhuff
    mjhuff committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    da27bb1 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. spruce up connect

    @mjhuff
    mjhuff committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    466d03d View commit details
    Browse the repository at this point in the history

  2. spruce ub subscribe

    @mjhuff
    mjhuff committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    d0ca3da View commit details
    Browse the repository at this point in the history

  3. spruce up unsubscribe

    @mjhuff
    mjhuff committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    fc73504 View commit details
    Browse the repository at this point in the history

  4. some cleanup

    @mjhuff
    mjhuff committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    9a00811 View commit details
    Browse the repository at this point in the history

  5. log.ts -> notifyLog.ts

    @mjhuff
    mjhuff committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    75939dc View commit details
    Browse the repository at this point in the history

  6. promise

    @mjhuff
    mjhuff committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    f403610 View commit details
    Browse the repository at this point in the history

  7. random cleanup

    @mjhuff
    mjhuff committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    9b2cb25 View commit details
    Browse the repository at this point in the history

  8. DRY up the sendToBrowser logic

    @mjhuff
    mjhuff committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    785744c View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. use the top level name property from discovery-client to prevent redu… 

    …ndant connections
    @mjhuff
    mjhuff committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    cb7f8d1 View commit details
    Browse the repository at this point in the history

  2. disconnect from hosts as they become unreachable

    @mjhuff
    mjhuff committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    107efcd View commit details
    Browse the repository at this point in the history

  3. cleanup

    @mjhuff
    mjhuff committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    dcd45a7 View commit details
    Browse the repository at this point in the history

  4. properly handle associated host connection & disconnection

    @mjhuff
    mjhuff committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    5731094 View commit details
    Browse the repository at this point in the history

  5. we mean ip, not hostname

    @mjhuff
    mjhuff committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    954288f View commit details
    Browse the repository at this point in the history

  6. P R O M I S I F Y (and add errors)

    @mjhuff
    mjhuff committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1d6800e View commit details
    Browse the repository at this point in the history

  7. fix a couple booleans

    @mjhuff
    mjhuff committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    264ee27 View commit details
    Browse the repository at this point in the history

  8. let's add robotName to error messages

    @mjhuff
    mjhuff committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    e2f5485 View commit details
    Browse the repository at this point in the history

  9. retry on other IPs if current is port blocked

    @mjhuff
    mjhuff committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    dcd0b5b View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. cleanup connectivity

    @mjhuff
    mjhuff committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    c25f0ce View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. feedback

    @mjhuff
    mjhuff committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    2fb099c View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. a few random fixes

    @mjhuff
    mjhuff committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    5313b98 View commit details
    Browse the repository at this point in the history

  2. some tests

    @mjhuff
    mjhuff committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    d18d2f8 View commit details
    Browse the repository at this point in the history