refactor(api): Split CommandStore #14647
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This file has been a bit uncomfortably bloated for a while. It's responsible for at least two broad areas:
The other problem is that it uses the old test style of splitting the store from the view. This creates thousands of lines of tests that don't pull their weight in catching bugs, and, I find, make it harder to work on this file.
All of this has contributed to maintenance problems (here are apparently two different ways of computing the same thing, for example), and performance problems past and ongoing.
This is going to get worse because of error recovery, which will add new run states and maybe command states.
So, the plan here is:
Test Plan
Changelog
Review requests
Risk assessment