-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app): firmware update in progress modal graphic #14484
Conversation
Replaces in progress bar in subsystem firmware updates with a spinner per designs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #14484 +/- ##
==========================================
+ Coverage 67.34% 67.55% +0.20%
==========================================
Files 2485 2493 +8
Lines 71417 71342 -75
Branches 9042 9030 -12
==========================================
+ Hits 48099 48197 +98
+ Misses 21173 20983 -190
- Partials 2145 2162 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per slack convo with Sue, let's show a green checkmark if no firmware update is required, otherwise show the spinner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for fixing this, @nickcrider and @mjhuff !
closes RQA-2343 and EXEC-329 Co-authored-by: Jamey Huffnagle <[email protected]>
closes RQA-2343 and EXEC-329
Overview
Replaces in progress bar in subsystem firmware updates with a spinner per designs.
Jamey update - we also display a green check mark if there is no update (not per designs, but per Sue)
Screen.Recording.2024-03-14.at.2.45.25.PM.mov
Test Plan
Two methods:
currentStepIndex
forcurrentStep
in L221 to2
. Launch the attach flows for an instrument.Risk assessment
low