Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): adjust config fixture base stroke and position #14316

Merged
merged 7 commits into from
Jan 18, 2024

Conversation

brenthagen
Copy link
Contributor

@brenthagen brenthagen commented Jan 12, 2024

Overview

provides additional spacing between config fixtures by adding a stroke to the base SVG and adjusting positioning accordingly

Screen Shot 2024-01-17 at 12 25 50 PM

closes RAUT-867

Test Plan

visually verified deck configurator

Changelog

  • Adjusts deck configurator config fixture spacing

Review requests

Risk assessment

low

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (cb819ee) 68.12% compared to head (91a7ec5) 68.10%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14316      +/-   ##
==========================================
- Coverage   68.12%   68.10%   -0.03%     
==========================================
  Files        2513     2513              
  Lines       71495    71430      -65     
  Branches     9078     9076       -2     
==========================================
- Hits        48708    48648      -60     
+ Misses      20684    20679       -5     
  Partials     2103     2103              
Flag Coverage Δ
app 65.49% <ø> (ø)
components 48.94% <58.82%> (-1.38%) ⬇️
labware-library 41.10% <ø> (ø)
protocol-designer 35.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...nts/src/hardware-sim/DeckConfigurator/constants.ts 100.00% <100.00%> (ø)
...onents/src/hardware-sim/DeckConfigurator/index.tsx 67.74% <100.00%> (ø)
...rdware-sim/DeckConfigurator/EmptyConfigFixture.tsx 66.66% <50.00%> (-2.57%) ⬇️
...-sim/DeckConfigurator/StagingAreaConfigFixture.tsx 0.00% <0.00%> (-11.77%) ⬇️
...are-sim/DeckConfigurator/TrashBinConfigFixture.tsx 0.00% <0.00%> (-11.77%) ⬇️
...e-sim/DeckConfigurator/WasteChuteConfigFixture.tsx 0.00% <0.00%> (-10.53%) ⬇️

... and 24 files with indirect coverage changes

@brenthagen brenthagen marked this pull request as ready for review January 17, 2024 17:27
@brenthagen brenthagen requested a review from a team as a code owner January 17, 2024 17:27
@brenthagen brenthagen requested review from mjhuff and a team and removed request for a team and mjhuff January 17, 2024 17:27
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brenthagen brenthagen merged commit c897edd into edge Jan 18, 2024
47 of 48 checks passed
@brenthagen brenthagen deleted the components_config-fixture-spacing branch January 18, 2024 16:51
mjhuff pushed a commit that referenced this pull request Jan 23, 2024
…14316)

provides additional spacing between config fixtures by adding a stroke to the base SVG and adjusting
positioning accordingly

closes RAUT-867
ncdiehl11 pushed a commit that referenced this pull request Feb 1, 2024
…14316)

provides additional spacing between config fixtures by adding a stroke to the base SVG and adjusting
positioning accordingly

closes RAUT-867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants