-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(components): adjust config fixture base stroke and position #14316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provides additional spacing between config fixtures by adding a stroke to the base SVG and adjusting positioning accordingly closes RAUT-867
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## edge #14316 +/- ##
==========================================
- Coverage 68.12% 68.10% -0.03%
==========================================
Files 2513 2513
Lines 71495 71430 -65
Branches 9078 9076 -2
==========================================
- Hits 48708 48648 -60
+ Misses 20684 20679 -5
Partials 2103 2103
Flags with carried forward coverage won't be shown. Click here to find out more.
|
koji
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
provides additional spacing between config fixtures by adding a stroke to the base SVG and adjusting positioning accordingly
closes RAUT-867
Test Plan
visually verified deck configurator
Changelog
Review requests
Risk assessment
low