Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add new status checks for module calibration #13393

Closed

Conversation

koji
Copy link
Contributor

@koji koji commented Aug 25, 2023

Overview

Add new status checks for module calibration. Check pipette status to display new text.
Check module calibration status to display calibrate button.

close RAUT-553

Test Plan

Changelog

Review requests

Risk assessment

Check pipette status for module calibration

close RAUT-553
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #13393 (33db053) into chore_release-7.0.0 (7d6d2f8) will decrease coverage by 0.06%.
Report is 9 commits behind head on chore_release-7.0.0.
The diff coverage is 5.71%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.0.0   #13393      +/-   ##
=======================================================
- Coverage                71.67%   71.62%   -0.06%     
=======================================================
  Files                     2427     2431       +4     
  Lines                    67585    68043     +458     
  Branches                  7791     7986     +195     
=======================================================
+ Hits                     48439    48733     +294     
- Misses                   17316    17452     +136     
- Partials                  1830     1858      +28     
Flag Coverage Δ
app 69.64% <5.71%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
app/src/organisms/ProtocolSetupModules/index.tsx 27.77% <5.71%> (-12.23%) ⬇️

... and 21 files with indirect coverage changes

@koji koji changed the base branch from edge to chore_release-7.0.0 August 28, 2023 16:27
@koji
Copy link
Contributor Author

koji commented Aug 28, 2023

  • add test cases

@koji koji marked this pull request as ready for review August 28, 2023 22:04
@koji koji requested a review from a team as a code owner August 28, 2023 22:04
@koji koji requested review from jerader, b-cooper, shlokamin and a team and removed request for a team, jerader, b-cooper and shlokamin August 28, 2023 22:04
@koji koji marked this pull request as draft August 29, 2023 13:20
@koji koji closed this Aug 29, 2023
@koji
Copy link
Contributor Author

koji commented Aug 29, 2023

This will be fixed in a following PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant