-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(api): split backend tip_action into two functions #13381
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13381 +/- ##
=======================================
Coverage 71.67% 71.67%
=======================================
Files 2405 2405
Lines 67012 67010 -2
Branches 7654 7654
=======================================
- Hits 48029 48028 -1
+ Misses 17163 17162 -1
Partials 1820 1820
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure this is tested on a robot beforehand, but looks good overall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense,
go to go once we get some testing on the robot.
02fb93c
to
bdcc6e6
Compare
Overview
Currently, the backend
tip_action
function is used both for regular tip action moves, as well as for homing the gear motors at a constant velocity. This makes the code a little bit cluttered, as the backend function takes in either a list of moves or a distance and velocity to accommodate this, and then needs to determine which one it's received.Instead, the api can just use two separate functions- one for homing, and one for all other moves involving the gear motor.
Changelog
home_gear_motors
function inot3api.py
that fast homes the gear motors if possible, or homes at constant velocity if nothome_gear_motors
function inot3controller.py
that is used only for homing at constant velocityot3controller.py::tip_action
will only take in a list of moves