Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add module calibrate button to protocol setup #13380

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

koji
Copy link
Contributor

@koji koji commented Aug 24, 2023

Overview

Add module calibrate button to protocol setup and update tests

Screenshot 2023-08-24 at 3 39 02 PM

close RAUT-555

Test Plan

  1. upload a protocol that requires a module
  2. attache a module
  3. set up a protocol

Changelog

  • modify module setup status part to add calibrate button
  • update tests and add a new test for calibrate button

Review requests

Risk assessment

low

add calibrate button to Desktop app protocol setup

close RAUT-555
@koji koji requested a review from a team August 24, 2023 20:00
@koji koji changed the base branch from edge to chore_release-7.0.0 August 24, 2023 20:01
@koji koji marked this pull request as ready for review August 24, 2023 20:02
@koji koji requested a review from a team as a code owner August 24, 2023 20:02
@koji koji requested review from shlokamin and removed request for a team August 24, 2023 20:02
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #13380 (2850277) into chore_release-7.0.0 (f11a7b7) will decrease coverage by 0.12%.
Report is 2 commits behind head on chore_release-7.0.0.
The diff coverage is 87.50%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.0.0   #13380      +/-   ##
=======================================================
- Coverage                71.69%   71.58%   -0.12%     
=======================================================
  Files                     2427     2427              
  Lines                    67572    67764     +192     
  Branches                  7782     7858      +76     
=======================================================
+ Hits                     48443    48506      +63     
- Misses                   17301    17420     +119     
- Partials                  1828     1838      +10     
Flag Coverage Δ
app 69.60% <87.50%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ices/ProtocolRun/SetupModules/SetupModulesList.tsx 91.11% <87.50%> (-1.00%) ⬇️

... and 7 files with indirect coverage changes

@koji koji removed the request for review from shlokamin August 24, 2023 20:02
moduleFromProtocol={heaterShakerModuleFromProtocol}
attachedModule={heaterShakerAttachedModule}
<>
{showModuleWizard && attachedModuleMatch != null ? (
Copy link
Contributor

@mjhuff mjhuff Aug 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{showModuleWizard && attachedModuleMatch != null ? (
{showModuleWizard ? (

Nitpicking, but Is the attachedModuleMatch check necessary here? The only way we can show the wizard is if the button is clicked?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added attachedModuleMatch != null because of ModuleWiardFlowProps.

interface ModuleWizardFlowsProps {
  attachedModule: AttachedModule
  closeFlow: () => void
  slotName?: string
  onComplete?: () => void
}

Actually I wrote {showModuleWizard ? ( first and got an error.

Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Lgtm with the one question 🚀

@koji koji merged commit 1b9c82c into chore_release-7.0.0 Aug 25, 2023
20 of 22 checks passed
@koji koji deleted the app_module-calibration-protocol-setup branch August 25, 2023 20:40
TamarZanzouri pushed a commit that referenced this pull request Sep 13, 2023
* feat(app): add calibrate button to Desktop app protocol setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants