Skip to content

Commit

Permalink
Use placeholder implementation instead of raising NotImplementedError.
Browse files Browse the repository at this point in the history
This seems a little more friendly to UI tests.
  • Loading branch information
SyntaxColoring committed Oct 23, 2024
1 parent 964d2c0 commit c36ceef
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion robot-server/robot_server/runs/error_recovery_mapping.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def _map_error_recovery_type(reaction_if_match: ReactionIfMatch) -> ErrorRecover
case ReactionIfMatch.ASSUME_FALSE_POSITIVE_AND_CONTINUE:
# todo(mm, 2024-10-23): Connect to work in
# https://github.com/Opentrons/opentrons/pull/16556.
raise NotImplementedError
return ErrorRecoveryType.IGNORE_AND_CONTINUE
case ReactionIfMatch.FAIL_RUN:
return ErrorRecoveryType.FAIL_RUN
case ReactionIfMatch.WAIT_FOR_RECOVERY:
Expand Down
2 changes: 1 addition & 1 deletion robot-server/robot_server/runs/run_controller.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def create_action(
):
# todo(mm, 2024-10-23): Connect to work in
# https://github.com/Opentrons/opentrons/pull/16556.
raise NotImplementedError
self._run_orchestrator_store.resume_from_recovery()

else:
assert_never(action_type)
Expand Down

0 comments on commit c36ceef

Please sign in to comment.