Skip to content

Commit

Permalink
Cleanup.
Browse files Browse the repository at this point in the history
  • Loading branch information
SyntaxColoring committed Jan 10, 2024
1 parent 26e9a38 commit 41a5242
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 24 deletions.
23 changes: 0 additions & 23 deletions api/src/opentrons/protocol_engine/execution/pipetting.py
Original file line number Diff line number Diff line change
Expand Up @@ -264,29 +264,6 @@ def _validate_dispense_volume(
self, pipette_id: str, dispense_volume: float
) -> float:
"""Validate dispense volume."""
# TODO:
#
# Does this code belong here, or in PipetteView?
#
#
# TODO: Does it matter what order we do the subtraction in?
#
# remaining = aspirated - dispensed
# if remaining >= -_TOLERANCE:
# ok, clamp to 0 remaining
# else:
# error
#
#
# vs.
#
#
# available = aspirated + _TOLERANCE
# if dispensed <= available
# ok, clamp to 0 remaining
# else:
# error

aspirated_volume = self._state_view.pipettes.get_aspirated_volume(pipette_id)
if aspirated_volume is None:
raise InvalidDispenseVolumeError(
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""Pipetting execution handler."""
from typing import cast, Optional
from typing import cast

import pytest
from decoy import Decoy
Expand Down

0 comments on commit 41a5242

Please sign in to comment.