Skip to content

Commit

Permalink
remove last of unrelated code
Browse files Browse the repository at this point in the history
  • Loading branch information
b-cooper committed Jun 21, 2024
1 parent f9a2d48 commit 0344070
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 10 deletions.
3 changes: 1 addition & 2 deletions robot-server/robot_server/protocols/analysis_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from opentrons.protocol_engine.types import RunTimeParameter, RunTimeParamValuesType
from opentrons_shared_data.robot.dev_types import RobotType
from pydantic import BaseModel, Field
from typing import Any, List, Optional, Union, NamedTuple
from typing import List, Optional, Union, NamedTuple
from typing_extensions import Literal

from opentrons.protocol_engine import (
Expand Down Expand Up @@ -189,7 +189,6 @@ class CompletedAnalysis(BaseModel):
default_factory=list,
description="Liquids used by the protocol",
)
commandAnnotations: List[Any] = Field(default_factory=list)


AnalysisParameterType = Union[float, bool, str, None]
Expand Down
5 changes: 1 addition & 4 deletions robot-server/robot_server/protocols/analysis_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@

import sqlalchemy
from logging import getLogger
from typing import Any, Dict, List, Optional

from typing import Dict, List, Optional
from typing_extensions import Final

from opentrons_shared_data.robot.dev_types import RobotType
Expand Down Expand Up @@ -153,7 +152,6 @@ async def update(
pipettes: List[LoadedPipette],
errors: List[ErrorOccurrence],
liquids: List[Liquid],
command_annotations: List[Any],
) -> None:
"""Promote a pending analysis to completed, adding details of its results.
Expand Down Expand Up @@ -203,7 +201,6 @@ async def update(
pipettes=pipettes,
errors=errors,
liquids=liquids,
commandAnnotations=command_annotations,
)
completed_analysis_resource = CompletedAnalysisResource(
id=completed_analysis.id,
Expand Down
1 change: 0 additions & 1 deletion robot-server/robot_server/protocols/protocol_analyzer.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ async def analyze(
pipettes=result.state_summary.pipettes,
errors=result.state_summary.errors,
liquids=result.state_summary.liquids,
command_annotations=protocol_resource.source.command_annotations,
)

async def update_to_failed_analysis(
Expand Down
2 changes: 0 additions & 2 deletions shared-data/js/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import type {
import type { RunTimeCommand, LabwareLocation } from '../command/types'
import type { AddressableAreaName, CutoutFixtureId, CutoutId } from '../deck'
import type { PipetteName } from './pipettes'
import { CommandAnnotation } from '../commandAnnotation/types'

export type RobotType = 'OT-2 Standard' | 'OT-3 Standard'

Expand Down Expand Up @@ -687,7 +686,6 @@ export interface CompletedProtocolAnalysis {
errors: AnalysisError[]
robotType?: RobotType | null
runTimeParameters?: RunTimeParameter[]
commandAnnotations?: CommandAnnotation[]
}

export interface ResourceFile {
Expand Down
1 change: 0 additions & 1 deletion shared-data/protocol/types/schemaV8/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ export interface ProtocolAnalysisOutput {
errors: AnalysisError[]
runTimeParameters: RunTimeParameter[]
robotType?: RobotType
commandAnnotations?: CommandAnnotation[]
result: 'ok' | 'not-ok' | 'error' | 'parameter-value-required'
}

Expand Down

0 comments on commit 0344070

Please sign in to comment.