Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flex-stacker): clear ack message cache when a stall is detected. #474

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Nov 7, 2024

Overview

This fixes an issue where the ack cache would get full when a stall occurred because the incoming move message was not getting the expected response. So let's clear the ack cache when we get a stall before we send an error message.

Testing

  • Trigger multiple stalls and make sure we no longer get gcode cache full messages

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I think. This means that the python side is expected to cancel its tracking of any in-flight moves when it gets a stall, right?

Copy link
Contributor

@ahiuchingau ahiuchingau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@vegano1
Copy link
Contributor Author

vegano1 commented Nov 7, 2024

Looks good I think. This means that the python side is expected to cancel its tracking of any in-flight moves when it gets a stall, right?

yeah that's correct.

@vegano1 vegano1 merged commit 155c057 into edge Nov 7, 2024
6 of 7 checks passed
@vegano1 vegano1 deleted the flex-stacker-gparser-full-fix branch November 7, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants