Gh teams improvements #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* list_teams() returns a dataframe when use_names = FALSE * list_team_members compares team name agains slug
|
@ateucher is this ready for review? |
|
Yes, thanks @seankross! |
seankross
requested changes
Dec 4, 2024
teams with parents show up as one row
seankross
approved these changes
Dec 6, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we need more metadata about a team or a member than than just the name (especially the slug, in the case of
list_team_members()), so this allows returning a data frame of team metadata fromlist_teams()andlist_team_members(), rather than the rawghresponse or a character vector of names.This is used in
list_team_members()to validate the supplied team against the slug.