CI for cross platform compilation and apple device metadata refactor #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't quite ready to merge but I wanted to discuss at this current state.
First off the existing package only works on iOS at the moment due to issues with dependencies on the conditional blocks. I'm working on a cross platform app targeting macOS, iOS, and tvOS and implementing OpenPanel. (By the way the OpenPanel docs don't mention this SDK existing -- luckily i checked github issues before trying to build one myself)
This branch accomplishes two things primarily:
xcodebuild
to actually run. Supposedly it worked with just plain packages in the past but I couldn't get it to and docs are sparse._global
at init. Because of theisServer
checks on the OpenPanel side at least a minimal user agent is need like"Mozilla/5.0 (iPhone; U)"
to avoid that (though that side of things could be refactored too I suppose).I think it would be good to get rid of the whole
WKWebView
dependency for iOS. Is there any value in getting this UserAgent when using OpenPanel for apps?Here is an example of tracking the apple model identifier instead of the more generic Macintosh or iPhone for all devices.
