refactor(contracts): upgrade math contracts 0.28.0

.github/actions/setup/action.yml

@@ -14,6 +14,7 @@ runs:
       uses: actions/checkout@v4
       with:
         fetch-depth: 1
+        submodules: recursive
 
     - name: Set Compact environment variables
       shell: bash
@@ -75,26 +76,42 @@ runs:
         node-version: '22.x'
         cache: 'pnpm'
 
-    - name: Build compact package
+    - name: Enable Corepack for Yarn
+      shell: bash
+      run: corepack enable
+
+    - name: Build compact-tools submodule
       shell: bash
       run: |
-        cd packages/compact
-        pnpm install
-        pnpm run build
+        echo "📦 Building compact-tools submodule..."
+        cd compact-tools
+        yarn install --immutable
+        yarn build
+        echo "✅ compact-tools built successfully"
 
-    - name: Validate build artifacts
+    - name: Validate compact-tools artifacts
       shell: bash
       run: |
         REQUIRED_FILES=(
-          "packages/compact/dist/runCompiler.js"
-          "packages/compact/dist/runBuilder.js"
+          "compact-tools/packages/cli/dist/runCompiler.js"
+          "compact-tools/packages/cli/dist/runBuilder.js"
         )
         for file in "${REQUIRED_FILES[@]}"; do
           if [ ! -f "$file" ]; then
             echo "::error::❌ Missing required file: $file"
             exit 1
           fi
         done
+        echo "✅ compact-tools artifacts validated"
+
+    - name: Build compact-contracts submodule
+      shell: bash
+      run: |
+        echo "📦 Building compact-contracts submodule..."
+        cd compact-contracts
+        yarn install --immutable
+        SKIP_ZK=true yarn compact
+        echo "✅ compact-contracts built successfully"
 
     - name: Install dependencies
       shell: bash

.github/workflows/apps.yml

@@ -25,6 +25,7 @@ jobs:
         uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
         with:
           fetch-depth: 1
+          submodules: recursive
 
       - name: Setup Environment
         uses: ./.github/actions/setup

.github/workflows/checks.yml

@@ -24,6 +24,7 @@ jobs:
         uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
         with:
           fetch-depth: 0
+          submodules: recursive
 
       - name: Setup Environment
         uses: ./.github/actions/setup

.github/workflows/contracts.yml

@@ -25,6 +25,7 @@ jobs:
         uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
         with:
           fetch-depth: 2 # Recommended by turbo team
+          submodules: recursive
 
       - name: Setup Environment
         uses: ./.github/actions/setup

.gitmodules

@@ -0,0 +1,7 @@
+[submodule "compact-tools"]
+	path = compact-tools
+	url = https://github.com/OpenZeppelin/compact-tools
+
+[submodule "compact-contracts"]
+	path = compact-contracts
+	url = https://github.com/OpenZeppelin/compact-contracts

README.md

@@ -1,9 +1,9 @@
-# Midnight DApps
+# Midnight Apps 
 
 [![License](https://img.shields.io/badge/license-MIT-green.svg?style=flat)](https://opensource.org/licenses/MIT)
 [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/OpenZeppelin/midnight-apps/badge)](https://api.securityscorecards.dev/projects/github.com/OpenZeppelin/midnight-apps)
 
-A collection of starter dapps on the Midnight Network
+A collection of sample (starter) apps on the Midnight Network
 
 ## Overview
 This monorepo contains experimental sample projects built on top of the Midnight Network using Compact. It includes contract, utility, and application code.
@@ -33,33 +33,59 @@ compact --version
 ```
 
 ### Setup
-1. **Clone the Repository**:
+1. **Clone the Repository with Submodules**:
    ```bash
-   git clone <repository-url>
-   cd openzeppelin-midnight-apps
+   git clone --recurse-submodules <repository-url>
+   cd midnight-apps
    ```
+
+   If you already cloned without submodules, initialize them:
+   ```bash
+   git submodule update --init --recursive
+   ```
+
+2. **Build the compact-tools Submodule**:
+   ```bash
+   cd compact-tools
+   yarn install
+   yarn build
+   cd ..
+   ```
+   This builds the CLI tools (`compact-compiler`, `compact-builder`) required by the contracts.
 
-2. **Install Dependencies**:
+3. **Build the compact-contracts Submodule**:
+   ```bash
+   cd compact-contracts
+   yarn install
+   SKIP_ZK=true yarn compact
+   cd ..
+   ```
+   This compiles the OpenZeppelin Compact contracts library.
+
+4. **Install Main Project Dependencies**:
    ```bash
    pnpm install
    ```
-   - This installs all workspace dependencies and runs the `prepare` script, which sets up Husky and builds `@openzeppelin/midnight-apps-compact`.
+   This installs all workspace dependencies and runs the `prepare` script, which sets up Husky.
 
-3. **Workspace Structure**:
-   - `contracts/*`: Compact Smart contract projects (e.g., `@openzeppelin/midnight-apps-access-contract`).
-   - `packages/*`: Utility packages (e.g., `@openzeppelin/midnight-apps-compact`).
-   - `apps/*`: Frontend applications (e.g., `@openzeppelin/midnight-apps-lunarswap-ui`).
+5. **Workspace Structure**:
+   - `compact-tools/`: Git submodule - CLI tools for compiling Compact contracts.
+   - `compact-contracts/`: Git submodule - OpenZeppelin Compact contracts library.
+   - `contracts/`: Compact smart contract projects for this repo.
+   - `packages/`: Utility packages (e.g., `@openzeppelin/midnight-apps-logger`).
+   - `apps/`: Frontend applications (e.g., `@openzeppelin/midnight-apps-lunarswap-ui`).
 
    See `pnpm-workspace.yaml` for the full list.
 
-4. **Build Contracts Packages**:
+6. **Build Contracts Packages**:
+   ```bash
+   pnpm build:contracts
+   ```
+   Or navigate to individual contract packages:
    ```bash
-   # Navigate to each contract package and run build
-   cd contracts/access && pnpm build 
-   cd ../math && pnpm build
-   cd ../structs && pnpm build
+   cd contracts && pnpm build
    ```
-   - **Note**: Running `pnpm build:contracts`, `pnpm compact`, `pnpm compact:fast`, `pnpm compact:version`, or `pnpm compact:language-version` from the root may cause repetitive output due to Turbo's logging behavior. It's recommended to compile contracts individually from within each package directory.
+   - **Note**: Running `pnpm compact`, `pnpm compact:fast`, `pnpm compact:version`, or `pnpm compact:language-version` from the root may cause repetitive output due to Turbo's logging behavior.
    - **Feature Request**: A logging output mode flag is being requested to fix Turbo animation log flooding. See [GitHub Issue #1188](https://github.com/midnightntwrk/compactc/issues/1188) for more details.
 
 ### Tasks with Turbo

apps/lunarswap-ui/package.json

@@ -6,9 +6,9 @@
     "dev": "next dev",
     "build": "next build",
     "start": "next start",
-    "fmt": "biome format --write",
-    "lint": "biome lint",
-    "lint:fix": "biome check --write",
+    "lint": "biome check . && next lint",
+    "lint:fix": "biome check . --write",
+    "lint:ci": "biome ci . --changed --since=main --no-errors-on-unmatched",
     "githook:precommit": "lint-staged && pnpm run types"
   },
   "dependencies": {