Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Call of Chernobyl 1.4.22 (#1529) #1708

Open
wants to merge 203 commits into
base: dev
Choose a base branch
from

Conversation

Xottab-DUTY
Copy link
Member

No description provided.

- commented unused _Dedicated copy (last file)
+ fixed project dependencies (resources), now entire solution compiles without errors
+ fixed existing macros to use *Root* macros defines instead of $(Solution)*
+ moved all VS build related folders (bin, intermediate, lib, etc...) out of solution folder
+ added xrGame and xrGameBin macros
+ changed Debug config to generate game related DLLs in game folder (defined by environment variable XRAY_16X_GAME)
- removed some projects (dedicated, editor, plugins) from build list in Debug configuration
+ code format: untabify
Console commands added:
+ fov
+ hud_fov
+ g_god
+ add g_unlimitedammo
+ jump_to_level
+ run_script
+ run_string
+ time_factor
+ fixed invalid (had extra space) name of exported script function speed in alife_monster_detail_path_manager_script.cpp
+ flush script command
! restricted console commands relevant to debugging (g_god, run_string, etc..) to only be available when program was started with -dbg key
* added LuaJIT-1.1.8 project
* added LuaJIT-1.1.8 project
Conflicts:
	src/3rd party/LuaJIT-1.1.8/LuaJIT-1.1.8.vcxproj
	src/3rd party/LuaJIT-1.1.8/LuaJIT-1.1.8.vcxproj.filters
	src/xrServerEntities/script_storage.cpp
+ build_config_defines.h - take some control over ever growing number of changes

Script callbacks (examples in bind_stalker.script)
+ key_press
+ key_release (disabled in build_config_defines.h)
+ key_hold (disabled in build_config_defines.h)
+ mouse_move (disabled in build_config_defines.h)
+ move_wheel
+ item_to_ruck
+ item_to_belt
+ item_to_slot

Misc:
+ first person death (configurable in build_config_defines.h)
@Xottab-DUTY Xottab-DUTY added UI Lua pending review Player Experience Modmaker Experience Modmaker experience with OpenXRay Mods This issue is related to mods. Breaking change This breaks saves compatibility, or changes binary formats, etc. labels Aug 9, 2024
@Xottab-DUTY Xottab-DUTY linked an issue Aug 9, 2024 that may be closed by this pull request
3 tasks
@github-actions github-actions bot added the Game assets A feature or an issue that involves gamedata change label Aug 9, 2024
@Xottab-DUTY Xottab-DUTY force-pushed the feature/call_of_chernobyl branch 2 times, most recently from b5d786a to b65b542 Compare August 9, 2024 01:14
@Xottab-DUTY Xottab-DUTY mentioned this pull request Aug 9, 2024
3 tasks
@@ -135,6 +135,8 @@ SCRIPT_EXPORT(CUIActorMenu, (CUIDialogWnd),
.def("IsShown", &CUIActorMenu::IsShown)
.def("ShowDialog", &CUIActorMenu::ShowDialog)
.def("HideDialog", &CUIActorMenu::HideDialog)
.def("ToSlot", &CUIActorMenu::ToSlotScript)
.def("ToBelt", &CUIActorMenu::ToBeltScript)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А где остальные методы? SetMenuMode, GetMenuMode, GetPartner, GetInvBox, SetPartner, SetInvBox, SetActor

Copy link
Member Author

@Xottab-DUTY Xottab-DUTY Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Они из CoC 1.5, этот пул-реквест мёржит только 1.4.22 (переименовал его, чтобы не запутываться)

//Alundaio: To get the savegame fname to make our own custom save states
luabind::functor<void> funct1;
if (GEnv.ScriptEngine->functor("alife_storage_manager.CALifeStorageManager_before_save", funct1))
funct1((pcstr)m_save_name);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А куда пропали вызовы convert_path_separators, restore_path_separators? Надо проверить на Linux, не сломает ли это сохранения

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Они давно уже все внутри CLocatorAPI (и ещё в нескольких местах где нужно).
Не уверен насчёт этого места, может и нужно, проверить надо, да..

Copy link
Member Author

@Xottab-DUTY Xottab-DUTY Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

и ещё в нескольких местах где нужно

А лучше вообще без них, но это надо переписывать FS, так что это другая история))

@Xottab-DUTY Xottab-DUTY changed the title Merge Call of Chernobyl (#1529) Merge Call of Chernobyl 1.4.22 (#1529) Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Artificial Intelligence Breaking change This breaks saves compatibility, or changes binary formats, etc. Enhancement Game assets A feature or an issue that involves gamedata change Gameplay Lua Modmaker Experience Modmaker experience with OpenXRay Mods This issue is related to mods. pending review Physics Player Experience UI
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Launch Call of Chernobyl
6 participants