Dynamic boost indicators #1692
Open
Dynamic boost indicators #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamic position of boost icons
github-actions
bot
added
UI
Game assets
|
@Amx545, man, this is awesome! @Hrusteckiy, look! |
|
Finally someone did that! |
Added settings: Distance from indicators Vertical/horizontal alignment Inversion insert Maximum number of indicators in a row (column if vertical)
Xottab-DUTY
reviewed
Jun 16, 2024
src/xrGame/ui/UIBoostStatesWnd.cpp
Outdated
| Item->Show(false); | ||
| } | ||
| } | ||
| if(!influences.empty() || !m_ind_boost_pos.empty()) |
There was a problem hiding this comment.
Make sure to put a space between an if and the parens.
Suggested change
| if(!influences.empty() || !m_ind_boost_pos.empty()) | |
| if (!influences.empty() || !m_ind_boost_pos.empty()) |
src/xrGame/ui/UIBoostStatesWnd.cpp
Outdated
| flags |= LA_ONLYALPHA; | ||
| flags |= LA_TEXTURECOLOR; | ||
|
|
||
| for (const auto& [type, Item] : m_ind_boost_state) |
There was a problem hiding this comment.
Please, try to use other name. According to our code style, local variables should use camelCase (but snake_case is also allowed in some cases)
Some other local variables in your code also start with a capital letter, this needs to be fixed.
375gnu
reviewed
Jul 2, 2024
Comment on lines
+5
to
+13
| CUIBoostStatesWnd::CUIBoostStatesWnd() | ||
| : CUIWindow(CUIBoostStatesWnd::GetDebugType()) | ||
| { | ||
| bHorizontal = true; | ||
| bInverse = false; | ||
| dx = 0.f; | ||
| dy = 0.f; | ||
| maxItem = 8; | ||
| } |
There was a problem hiding this comment.
I believe more modern style is better:
Suggested change
| CUIBoostStatesWnd::CUIBoostStatesWnd() | |
| : CUIWindow(CUIBoostStatesWnd::GetDebugType()) | |
| { | |
| bHorizontal = true; | |
| bInverse = false; | |
| dx = 0.f; | |
| dy = 0.f; | |
| maxItem = 8; | |
| } | |
| CUIBoostStatesWnd::CUIBoostStatesWnd() | |
| : CUIWindow(CUIBoostStatesWnd::GetDebugType()), | |
| bHorizontal(true), | |
| bInverse(false), | |
| dx(0.f), | |
| dy(0.f), | |
| maxItem(8) | |
| { | |
| } |
actually in modern c++ it's recommended to initialize in declarations:
class CUIBoostStatesWnd final : public CUIWindow
{
// ...
private:
bool bHorizontal{ true };
bool bInverse{ false };
float dx{ 0.0f };
float dy{ 0.0f };
u8 maxItem{ 8 };
xr_vector<EBoostParams> indBoostPos;
xr_map<EBoostParams, CUIStatic*> indBoostState;
};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic position of booster icons depending on the order in which boosters are used.
