Redefine xr_string arguments of FS_File functions as reference.

OpenXRay · Oct 8, 2014 · 7202f23 · 7202f23
1 parent 6230526
commit 7202f23
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/xrCore/LocatorAPI_defs.cpp b/src/xrCore/LocatorAPI_defs.cpp
@@ -12,12 +12,12 @@
 //////////////////////////////////////////////////////////////////////
 // FS_File
 //////////////////////////////////////////////////////////////////////
-FS_File::FS_File(xr_string nm, long sz, time_t modif,unsigned attr)	{set(nm,sz,modif,attr);}
-FS_File::FS_File(xr_string nm)										{set(nm,0,0,0);}
+FS_File::FS_File(const xr_string& nm, long sz, time_t modif,unsigned attr)	{set(nm,sz,modif,attr);}
+FS_File::FS_File(const xr_string& nm)										{set(nm,0,0,0);}
 FS_File::FS_File(const _FINDDATA_T& f)								{set(f.name,f.size,f.time_write,(f.attrib&_A_SUBDIR)?flSubDir:0);}
-FS_File::FS_File(xr_string nm, const _FINDDATA_T& f)				{set(nm,f.size,f.time_write,(f.attrib&_A_SUBDIR)?flSubDir:0);}
+FS_File::FS_File(const xr_string& nm, const _FINDDATA_T& f)				{set(nm,f.size,f.time_write,(f.attrib&_A_SUBDIR)?flSubDir:0);}
 
-void FS_File::set(xr_string nm, long sz, time_t modif,unsigned attr)
+void FS_File::set(const xr_string& nm, long sz, time_t modif,unsigned attr)
 {
 	name		= nm;		xr_strlwr	(name);
 	size		= sz;

diff --git a/src/xrCore/LocatorAPI_defs.h b/src/xrCore/LocatorAPI_defs.h
@@ -56,13 +56,13 @@ struct XRCORE_API FS_File{
 	time_t	  	time_write;
 	long     	size;
 	xr_string	name;			// low-case name
-	void		set			(xr_string nm, long sz, time_t modif,unsigned attr);
+	void		set			(const xr_string& nm, long sz, time_t modif,unsigned attr);
 public:
 				FS_File		(){}
-				FS_File		(xr_string nm);
+				FS_File		(const xr_string& nm);
 				FS_File		(const _FINDDATA_T& f);
-				FS_File		(xr_string nm, const _FINDDATA_T& f);
-				FS_File		(xr_string nm, long sz, time_t modif,unsigned attr);
+				FS_File		(const xr_string& nm, const _FINDDATA_T& f);
+				FS_File		(const xr_string& nm, long sz, time_t modif,unsigned attr);
 	bool 		operator<	(const FS_File& _X) const	{return xr_strcmp(name.c_str(),_X.name.c_str())<0; }
 };
 DEFINE_SET		(FS_File,FS_FileSet,FS_FileSetIt);