st22: add interlace support #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test with st22p_interlaced_pcap.json and st22p_1v_1080i59.json Signed-off-by: Frank Du <[email protected]>
Signed-off-by: Frank Du <[email protected]>
ricmli
approved these changes
Dec 6, 2023
Signed-off-by: Frank Du <[email protected]>
frankdjx
pushed a commit
that referenced
this pull request
Dec 8, 2023
Following up on #628, I updated tx_st22p_get_encoder() to set the interlaced parameter in the st22_get_encoder_request struct. This change is critical for the parameter to get passed to any st22 plugins. I also updated the interlaced parameter type in the test json configurations, since interlaced is a boolean but was set as a string, and json-c defaults all strings as true. Signed-off-by: Cole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test with st22p_interlaced_pcap.json and st22p_1v_1080i59.json