Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcast: refactor igmp implementation #627

Merged
merged 9 commits into from
Dec 6, 2023

Conversation

ricmli
Copy link
Collaborator

@ricmli ricmli commented Dec 6, 2023

  1. Allow joining groups with source addresses
  2. Add sending leave membership report
  3. Allow membership report on query

@ricmli ricmli self-assigned this Dec 6, 2023
@ricmli ricmli marked this pull request as ready for review December 6, 2023 06:54
@ricmli ricmli requested a review from frankdjx as a code owner December 6, 2023 06:54
@ricmli
Copy link
Collaborator Author

ricmli commented Dec 6, 2023

I'd like to add some gtest for this, but multicast works differently with VFs, maybe I'll run the tests locally.

Copy link
Collaborator

@frankdjx frankdjx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, please update the json guide to include the new mcast_src_ip option.

And we may need register a mcast_stat by mt_stat_register call, to know how many mcast join sent with any source or single source, and the leave request.

lib/src/mt_mcast.c Show resolved Hide resolved
lib/src/mt_mcast.c Outdated Show resolved Hide resolved
lib/src/mt_mcast.c Show resolved Hide resolved
@ricmli ricmli enabled auto-merge (squash) December 6, 2023 08:51
@ricmli ricmli disabled auto-merge December 6, 2023 08:52
@ricmli ricmli merged commit 8ea0346 into OpenVisualCloud:main Dec 6, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants