Fix: Update validation-tests.yml pipenv install issues #1080
+426
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mionsz
requested review from
DawidWesierski4,
Sakoram,
skolelis and
Falron98
as code owners
Mionsz
force-pushed
the
validation-automation-install-pipenv
branch
15 times, most recently
from
c07c278 to
5855a2b
Compare
zLukas
requested changes
Feb 12, 2025
|
In my opionion, we should be able to run it loccally then use GHA as executor. This approach have two main benefits:
so my suggextion is to keep inputs, and triggers as it is, but encapsule/merge (to some extent) |
zLukas
requested changes
Feb 12, 2025
Fix: Update validation-tests.yml pipenv install issues and run issues Add: Multiple test cases run inputs Add: Dropdown for pre-release use cases Add: Fixtures.py time.sleep between runs Signed-off-by: Milosz Linkiewicz <[email protected]>
Fix: Fixed overall pytest/workflow run success rate by using single cases and retry approach Feature: Working inputs.validation-tests-2 input Feature: Type of bonding to use for validation run (Validation-iface-binding) Feature: Type of port_p and port_r to use for validation run (validation-test-port-p, validation-test-port-r) Signed-off-by: Milosz Linkiewicz <[email protected]>
Fixed: Set an timeout to 12h as tests can be lengthy Signed-off-by: Milosz Linkiewicz <[email protected]>
Mionsz
force-pushed
the
validation-automation-install-pipenv
branch
from
5855a2b to
3517e9f
Compare
Refactor: Moved validation tests run to script file Signed-off-by: Milosz Linkiewicz <[email protected]>
Mionsz
force-pushed
the
validation-automation-install-pipenv
branch
2 times, most recently
from
82249e0 to
88e0ec0
Compare
Mionsz
force-pushed
the
validation-automation-install-pipenv
branch
from
88e0ec0 to
5793ddb
Compare
Signed-off-by: Milosz Linkiewicz <[email protected]>
Mionsz
force-pushed
the
validation-automation-install-pipenv
branch
from
5793ddb to
9d9a2c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Update validation-tests.yml pipenv install issues