Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: st30_pipeline don't close until mbuf is free #1049

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

Sakoram
Copy link
Collaborator

@Sakoram Sakoram commented Jan 28, 2025

When tx_st30p_frame_done is called and subsequently framebuff->stat is set to ST30P_TX_FRAME_FREE, data from the framebuffer can still be in transport, already packetized and copied into rte_mbuf, waiting to be sent. Added sleep after last packet status is set to ST30P_TX_FRAME_FREE

@DawidWesierski4
Copy link
Collaborator

When tx_st30p_frame_done is called and subsequently framebuff->stat is set to ST30P_TX_FRAME_FREE, data from the framebuffer can still be in transport, already packetized and copied into rte_mbuf, waiting to be sent. Added sleep after last packet status is set to ST30P_TX_FRAME_FREE

hi there is a lot of description of the framebuff stat WA
But this patch also streamlines parsing of the sampling

do you mind also putting information about that ?

Copy link
Collaborator

@DawidWesierski4 DawidWesierski4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM fix the commit message though

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
When tx_st30p_frame_done is called and subsequently framebuff->stat is
set to ST30P_TX_FRAME_FREE, data from the framebuffer can still be in
transport, already packetized and copied into rte_mbuf, waiting to be
sent. Added sleep after last packet status is set to ST30P_TX_FRAME_FREE

Signed-off-by: Kasiewicz, Marek <[email protected]>
@Sakoram Sakoram force-pushed the fix_gst_st30p_tx branch 2 times, most recently from 570a628 to 70fd7ff Compare January 30, 2025 09:20
@Sakoram Sakoram merged commit 375536a into OpenVisualCloud:main Jan 30, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants