Fix: st30_pipeline don't close until mbuf is free #1049
Merged
+51
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakoram
requested review from
PanKaker,
DawidWesierski4,
skolelis and
Falron98
as code owners
hi there is a lot of description of the framebuff stat WA do you mind also putting information about that ? |
DawidWesierski4
approved these changes
Jan 28, 2025
When tx_st30p_frame_done is called and subsequently framebuff->stat is set to ST30P_TX_FRAME_FREE, data from the framebuffer can still be in transport, already packetized and copied into rte_mbuf, waiting to be sent. Added sleep after last packet status is set to ST30P_TX_FRAME_FREE Signed-off-by: Kasiewicz, Marek <[email protected]>
Sakoram
force-pushed
the
fix_gst_st30p_tx
branch
2 times, most recently
from
570a628 to
70fd7ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tx_st30p_frame_done is called and subsequently framebuff->stat is set to ST30P_TX_FRAME_FREE, data from the framebuffer can still be in transport, already packetized and copied into rte_mbuf, waiting to be sent. Added sleep after last packet status is set to ST30P_TX_FRAME_FREE