Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: y210le support in ffmpeg plugin #1029

Conversation

skolelis
Copy link
Collaborator

@skolelis skolelis commented Dec 23, 2024

Add support for Y210LE format in FFmpeg plugin on both RX and TX sides.

  • Implemented conversion using st_convert_api to convert Y210LE format to yuv422p10le for transport.

This is not the usual way of using MTL API it's done to support Intel Tiber and the non-standard way
of conversion in qsv Tiber pipelines.

@skolelis
Copy link
Collaborator Author

skolelis commented Dec 23, 2024

PR created basing on the patch in BCS. However after discussion with @DawidWesierski4 , better shorter smoother solution can be eventually created instead of these changes. So, hold on before merging to main!

@DawidWesierski4 DawidWesierski4 changed the title Add cartwheel mtl y210le support patch Add: cartwheel mtl y210le support patch Jan 21, 2025
@DawidWesierski4 DawidWesierski4 changed the title Add: cartwheel mtl y210le support patch Add: cartwheel mtl y210le support Jan 22, 2025
@DawidWesierski4
Copy link
Collaborator

@skolelis I thought we can save on the conversion, this format seems to be 16 bit and we have internal conversion devices
BUT I WAS WRONG

I checked it and it seems to be the easiest way of doing this
Im fine with the format just please correct linting errors

Fix the commit message to something sensible (without link) and i will give my approve ok ?

@DawidWesierski4 DawidWesierski4 changed the title Add: cartwheel mtl y210le support Add: y210le support Jan 22, 2025
@DawidWesierski4 DawidWesierski4 changed the title Add: y210le support Add: y210le support in ffmpeg plugin Jan 22, 2025
@skolelis skolelis force-pushed the patch_added_cartwheel_mtl_y210le_support branch from c772ed0 to 064f7b4 Compare January 22, 2025 10:31
@skolelis
Copy link
Collaborator Author

LGTM

@Sakoram
Copy link
Collaborator

Sakoram commented Jan 22, 2025

When initializing st20p session with ops_rx.transport_fmt != ops_rx.output_fmt it means that frames should be converted automatically by the session.
Could someone tell me why here the conversion is done "manually" by the ffmpeg plugin? Options:

  1. I'm wrong and this in not a feature of the pipeline mode. -> everything's fine, approve.
  2. I'm right -> please use this feature and remove invoking conversion from the plugin.

@DawidWesierski4
Copy link
Collaborator

When initializing st20p session with ops_rx.transport_fmt != ops_rx.output_fmt it means that frames should be converted automatically by the session. Could someone tell me why here the conversion is done "manually" by the ffmpeg plugin? Options:

  1. I'm wrong and this in not a feature of the pipeline mode. -> everything's fine, approve.
  2. I'm right -> please use this feature and remove invoking conversion from the plugin.

well i tested it a lil bit,
This was my assumption too buuuuuuuuut it didn't work oob
Mby its better to investigate it further

Copy link
Collaborator

@DawidWesierski4 DawidWesierski4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add in FFMPEG Readme an explicit statement that y210 is a format that is not supported by the ffmpeg plugins for mtl

@DawidWesierski4 DawidWesierski4 merged commit 8dad8fb into OpenVisualCloud:main Jan 24, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants