build: Use info fetched from version.m4#1006
Open
lcruz99 wants to merge 1 commit intoOpenVPN:masterfrom
Open
Conversation
flichtenheld
requested changes
Mar 25, 2026
config.h.cmake.in
Outdated
|
|
||
| /* The tap-windows id */ | ||
| #define TAP_WIN_COMPONENT_ID "tap0901" | ||
| #define TAP_WIN_COMPONENT_ID "${TAP_WIN_COMPONENT_ID}" |
Member
There was a problem hiding this comment.
Should use @TAP_WIN_COMPONENT_ID@ to be consistent with the rest of the file
lcruz99
force-pushed
the
cmake_fetch_win_vars_from_version_m4
branch
from
af3892c to
766252e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TAP-Windows driver configuration values (
TAP_WIN_COMPONENT_ID,TAP_WIN_MIN_MAJOR,TAP_WIN_MIN_MINOR) are being hardcoded directly in config.h.cmake.in:These same values are already defined in version.m4 as
PRODUCT_TAP_WIN_COMPONENT_ID,PRODUCT_TAP_WIN_MIN_MAJOR, andPRODUCT_TAP_WIN_MIN_MINOR.This PR makes cmake set these values to the already fetched metadata from version.m4 consistent with how other product version information is already managed.