Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #566

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Fix warnings #566

merged 3 commits into from
Jun 20, 2024

Conversation

anolpe
Copy link
Contributor

@anolpe anolpe commented Jun 13, 2024

WHY:

Advances #559

What has been changed (if possible, add screenshots, gifs, etc. )

version has been removed from docker-compose(.dev).yml files because it was obsolete:

WARN[0000] /home/antti/Documents/voting-advice-application/docker-compose.dev.yml: `version` is obsolete

Unnecessarry -- has been removed from yarn commands in Dockerfiles:

warning From Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded. In a future version, any explicit "--" will be forwarded as-is to the scripts.

candidate field has been added to Strapi plugin config:

warn: Users-permissions registration has defaulted to accepting the following additional user fields during registration: candidate

Strapi data transfer feature has been disabled because it is not used:

Warning: Missing transfer.token.salt: Data transfer features have been disabled.
Please set transfer.token.salt in config/admin.js (ex: you can generate one using Node with `crypto.randomBytes(16).toString('base64')`)

Following warning can't be fixed by us. There is issue about it in the repo of the package but it hasn't been fixed.

[vite-plugin-svelte] WARNING: The following packages have a svelte field in their package.json but no exports condition for svelte.
[email protected]
Please see https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/faq.md#missing-exports-condition for details.

Check off each of the following tasks as they are completed

  • I have reviewed the changes myself in this PR. Please check the self-review document
  • I have added or edited unit tests.
  • I have run the unit tests successfully.
  • I have run the e2e tests successfully.
  • I have tested this change on my own device.
  • I have tested this change on other devices (Using Browserstack is recommended).
  • I have tested my changes using the WAVE extension
  • I have added documentation where necessary.
  • Is there an existing issue linked to this PR?

Clean up your git commit history before submitting the pull request!

@kaljarv
Copy link
Contributor

kaljarv commented Jun 14, 2024

Could you also check if you can fix the maildev health check issue, which fails the e2e tests? On a quick look, this seems like a promising discussion: maildev/maildev#484

@anolpe anolpe marked this pull request as ready for review June 14, 2024 10:12
@kaljarv
Copy link
Contributor

kaljarv commented Jun 15, 2024

Strangely enough, now the Strapi container becomes unhealthy. @anolpe, could you investigate this contagion?

@anolpe anolpe force-pushed the fix-warnings branch 2 times, most recently from 411e222 to dc02e7f Compare June 19, 2024 13:00
Copy link
Contributor

@kaljarv kaljarv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anolpe anolpe merged commit 39fa13b into main Jun 20, 2024
8 checks passed
@anolpe anolpe deleted the fix-warnings branch June 20, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants