Writer: default audio pan to mid, can now be set via metadata #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timlehr
changed the title
timlehr
force-pushed
the
audioPan_tlehr
branch
from
ee968ce
to
cb8f594
Compare
timlehr
force-pushed
the
audioPan_tlehr
branch
from
717ac70
to
e033ff0
Compare
Signed-off-by: Tim Lehr <[email protected]>
Signed-off-by: Tim Lehr <[email protected]>
timlehr
force-pushed
the
audioPan_tlehr
branch
from
e033ff0
to
264fdaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #49
Summarize your change.
Before this change, a timeline with at least three clips would have its audio pan jump between
leftandmidand back toleft. This change defaults the pan to always be on center / mid and allows for the user to overwrite the pan values using metadata entries.Round tripping is not possible at this time, since the reader doesn't translate the parameter to the metadata dictionary yet.
Changed Tests
test_aaf_adapter