Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writer: Define essence description via OTIO metadata #48

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

timlehr
Copy link
Collaborator

@timlehr timlehr commented May 24, 2024

Summary

Simple PR that allows the default values for the essence descriptors to be overwritten using OTIO metadata.

Changed tests
- test_aaf_adapter.py

@timlehr timlehr requested a review from markreidvfx May 24, 2024 23:06
@timlehr timlehr self-assigned this May 24, 2024
@timlehr timlehr marked this pull request as ready for review May 24, 2024 23:07
@timlehr timlehr force-pushed the essenceDescriptor_tlehr branch 2 times, most recently from 1d7e88f to 1d23742 Compare October 8, 2024 20:18
@roger-sacilotto
Copy link

@timlehr Looks good to me

Copy link
Member

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by Roger Sacilotto

@meshula meshula merged commit 9b49540 into OpenTimelineIO:main Oct 15, 2024
36 checks passed
@timlehr timlehr deleted the essenceDescriptor_tlehr branch October 15, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants