Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTIO 0.17.0 Release Prep #33

Merged
merged 3 commits into from
Mar 24, 2024
Merged

Conversation

markreidvfx
Copy link
Member

Preparing the AAF adapter repo for release of OpenTimelineIO 0.17.0 that ships without adapters.

I tried my best to keep this somewhat matching the style of the ALE adapter. This repo is different in that it uses a wheel for all the tests. This is so we are testing the same thing that will users will install.

I also took the opportunity to convert the setup.py to pyproject.toml

I tried to update the codecov-action to v4 but they require some sort of token now that I'm not sure how to generate yet.

@markreidvfx markreidvfx changed the title Release Prep OTIO 0.17.0 Release Prep Feb 4, 2024
Copy link
Member

@apetrynet apetrynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Really no show-stopping comments, but left some in there for your consideration.

Also I think you'll need to update the python badge in "README.md" to add 3.11.
In the other adapters we fetch the tested python versions dynamically from the ci file.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
@meshula
Copy link
Member

meshula commented Feb 5, 2024

Note to @markreidvfx and reviewers: when landing this one please Merge, don't use Squash and Merge; it would be helpful to keep 0849fc2 as a separate commit in history.

Copy link
Member

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, approving pending updates per @apetrynet

@markreidvfx
Copy link
Member Author

markreidvfx commented Mar 24, 2024

@apetrynet it should be all good now, sorry for the delay. I removed the .dev1 like you suggested. I also added the dynamic badges, I didn't know that was a thing now :). I'll remove using @extract_adapters branch once it has been merged into the main OpenTimelineIO repo. I also rebased it on top of the current main.

@apetrynet apetrynet merged commit 9a2d295 into OpenTimelineIO:main Mar 24, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants