-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTIO 0.17.0 Release Prep #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Really no show-stopping comments, but left some in there for your consideration.
Also I think you'll need to update the python badge in "README.md" to add 3.11.
In the other adapters we fetch the tested python versions dynamically from the ci file.
Note to @markreidvfx and reviewers: when landing this one please Merge, don't use Squash and Merge; it would be helpful to keep 0849fc2 as a separate commit in history. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, approving pending updates per @apetrynet
Signed-off-by: Mark Reid <[email protected]>
Signed-off-by: Mark Reid <[email protected]>
Signed-off-by: Mark Reid <[email protected]>
0849fc2
to
26b6b25
Compare
@apetrynet it should be all good now, sorry for the delay. I removed the |
Preparing the AAF adapter repo for release of OpenTimelineIO 0.17.0 that ships without adapters.
I tried my best to keep this somewhat matching the style of the ALE adapter. This repo is different in that it uses a wheel for all the tests. This is so we are testing the same thing that will users will install.
I also took the opportunity to convert the
setup.py
topyproject.toml
I tried to update the
codecov-action
tov4
but they require some sort of token now that I'm not sure how to generate yet.